-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supported python versions #51
Comments
That is a good point. Currently, we are supporting Python 3.7 and above, which seems to be the most common minimum version for other database libraries as well 🤔 Not sure at the moment what the best way would be. Do you have any thoughts on how what we should do? |
I'm not entirely sure what the plan going forward should be. Personally, I would only support version 3.10+ however this is very controversial and I wouldn't recommend it for a public library such as this - For now I see no problem just ignoring the typing deprecations until most systems are running 3.10+ |
Yeah, that is indeed quite controversial 😅 |
I'll keep this open for discussion but you can mark it as stale if you want |
I don't believe that the Before we make a decision, further testing should be done on all versions of Python and OS (can be done this GitHub actions) to see if our clients work with versions 3.7+. I have noted that many libraries have already stopped supporting 3.7 in their latest releases. |
FYI: official tracking for the status of major Python versions is available here: Python 3.7 has been "End of life" for a while. As for typing specifically, import of __future__ annotations can allow for upgrading to the more "modern" typing for all Python versions (no need to limit that to >= 3.10). |
Description
What are your opinions on the python versions that should be supported by this library?
Asking this question due to the usage of deprecated typehinting annotations such as
typing.List
andtyping.Tuple
- what are our plans to support/update these annotations?Is there an existing issue for this?
Code of Conduct
The text was updated successfully, but these errors were encountered: