Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supported python versions #51

Open
2 tasks done
CaedenPH opened this issue Apr 3, 2023 · 6 comments
Open
2 tasks done

Supported python versions #51

CaedenPH opened this issue Apr 3, 2023 · 6 comments
Labels
documentation Improvements or additions to documentation wontfix This will not be worked on

Comments

@CaedenPH
Copy link
Contributor

CaedenPH commented Apr 3, 2023

Description

What are your opinions on the python versions that should be supported by this library?

Asking this question due to the usage of deprecated typehinting annotations such as typing.List and typing.Tuple - what are our plans to support/update these annotations?

Is there an existing issue for this?

  • I have searched the existing issues

Code of Conduct

  • I agree to follow this project's Code of Conduct
@CaedenPH CaedenPH added the documentation Improvements or additions to documentation label Apr 3, 2023
@AlexFrid
Copy link
Contributor

AlexFrid commented Apr 3, 2023

That is a good point. Currently, we are supporting Python 3.7 and above, which seems to be the most common minimum version for other database libraries as well 🤔

Not sure at the moment what the best way would be. Do you have any thoughts on how what we should do?

@CaedenPH
Copy link
Contributor Author

CaedenPH commented Apr 3, 2023

That is a good point. Currently, we are supporting Python 3.7 and above, which seems to be the most common minimum version for other database libraries as well 🤔

Not sure at the moment what the best way would be. Do you have any thoughts on how what we should do?

I'm not entirely sure what the plan going forward should be. Personally, I would only support version 3.10+ however this is very controversial and I wouldn't recommend it for a public library such as this - For now I see no problem just ignoring the typing deprecations until most systems are running 3.10+

@AlexFrid
Copy link
Contributor

AlexFrid commented Apr 3, 2023

Yeah, that is indeed quite controversial 😅
I'm sure there are a lot of enterprises still on Python 3.7 since its still widely supported in other similar libraries
We'll then just ignore it for now then 👍

@CaedenPH
Copy link
Contributor Author

CaedenPH commented Apr 3, 2023

Yeah, that is indeed quite controversial 😅 I'm sure there are a lot of enterprises still on Python 3.7 since its still widely supported in other similar libraries We'll then just ignore it for now then 👍

I'll keep this open for discussion but you can mark it as stale if you want

@AlexFrid AlexFrid closed this as not planned Won't fix, can't repro, duplicate, stale Apr 4, 2023
@AlexFrid AlexFrid reopened this Apr 4, 2023
@AlexFrid AlexFrid added the wontfix This will not be worked on label Apr 4, 2023
@Ce11an
Copy link
Contributor

Ce11an commented Apr 11, 2023

I don't believe that the typing module is going to be deprecated? It is needed to support all versions of Python, including 3.10. However, end of life for Python 3.7 is planned for this year.

Before we make a decision, further testing should be done on all versions of Python and OS (can be done this GitHub actions) to see if our clients work with versions 3.7+. I have noted that many libraries have already stopped supporting 3.7 in their latest releases.

@alexander-beedie
Copy link
Contributor

alexander-beedie commented Mar 20, 2024

FYI: official tracking for the status of major Python versions is available here:

Python 3.7 has been "End of life" for a while.
Python 3.8 will not be "End of life" until October 2024.

As for typing specifically, import of __future__ annotations can allow for upgrading to the more "modern" typing for all Python versions (no need to limit that to >= 3.10).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants