Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional white spaces and "carriage returns" added when commands are executed #53

Open
portslug opened this issue May 10, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@portslug
Copy link

Describe the bug
When executing atomic-operator on a windows 10 system, many tactics that are executed add additional white spaces and carriage returns to the commands. This can be observed in the output of the commands, or in the output logs.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Atomic Operator
  2. Execute any techniques related to PowerShell or windows account discovery enumeration. (This has also been observed across other techniques)
  3. Example1: Atomic-Operator run --techniques T1087.001 --select-tests
  4. Example2: Atomic-Operator run --techniques T1059.001 --select-tests
  5. See direct output or log file for details after commands are executed from the Atomic-Operator framework.

Screenshots
Please see screenshot for details related to added whitespace and carriage returns. Below in additional context area.

Desktop (please complete the following information):

  • OS: Windows 10 Pro - 10.0.19043 Build 19043 (x64)
  • Browser: Chrome

Additional context Screenshots
Image_01-2022-05-10

image_02-2022-05-10

@MSAdministrator
Copy link
Collaborator

@portslug Hey, sorry for the crazy long delay here - but looking at this it seems that the issue is with the output and not the command correct ? Just trying to verify before testing for myself.

The carriage returns and white spaces are from PowerShell (the shell) and how we process the different response streams from PowerShell itself. That being said, how do you think we should display this data - right now I just parse the response -> convert it to JSON (which adds/formats it to support JSON standards) but are thinking we should output the text output and log that instead of JSON ?

@MSAdministrator MSAdministrator added the enhancement New feature or request label Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants