audit AOs with optional parameters

[michaelficarra]

For example, the Call AO's argument list parameter is currently optional, which can make it a footgun for authors and a bit misleading for readers. We should make it mandatory. See tc39/proposal-upsert#65.

• ToPrimitive preferredType
• Call argumentsList
• Construct argumentsList
• Construct newTarget
• CreateListFromArrayLike validElementTypes
• Invoke argumentsList
• IteratorNext value
• ResolveBinding env
• OrdinaryObjectCreate additionalInternalSlotsList
• OrdinaryCreateFromConstructor internalSlotsList
• MakeConstructor writablePrototype
• MakeConstructor prototype
• SetFunctionName prefix
• CreateBuiltinFunction realm
• CreateBuiltinFunction prototype
• CreateBuiltinFunction prefix
• ArrayCreate proto
• ForIn/OfBodyEvaluation iteratorKind
• InstantiateOrdinaryFunctionExpression name
• InstantiateArrowFunctionExpression name
• DefineMethod functionPrototype
• InstantiateGeneratorFunctionExpression name
• InstantiateAsyncGeneratorFunctionExpression name
• InstantiateAsyncFunctionExpression name
• InstantiateAsyncArrowFunctionExpression name
• LoadRequestedModules hostDefined
• GetExportedNames exportStarSet
• ResolveExport resolveSet
• ExecuteModule capability
• FlattenIntoArray mapperFunction
• FlattenIntoArray thisArg
• AllocateTypedArray length
• AllocateArrayBuffer maxByteLength
• DetachArrayBuffer key
• GetValueFromBuffer isLittleEndian
• SetValueInBuffer isLittleEndian
• AllocateSharedArrayBuffer maxByteLength
• ValidateAtomicAccessOnIntegerTypedArray waitable
• PerformPromiseThen resultCapability
• CreateIteratorFromClosure extraSlots
• AsyncGeneratorCompleteStep realm

[ljharb]

I assume the goal here is to remove footguns, not to remove optional parameters entirely?

[michaelficarra]

It's to consider whether each optional parameter is a net negative or a net positive and remove the former.