Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password Input Concern #125

Open
mgifford opened this issue Mar 4, 2024 · 1 comment
Open

Password Input Concern #125

mgifford opened this issue Mar 4, 2024 · 1 comment

Comments

@mgifford
Copy link

mgifford commented Mar 4, 2024

I think it's neat how you've built this:

https://www.magentaa11y.com/checklist-web/password-input/

But shouldn't you be using aria-live to announce that the content has changed?

@joe-watkins
Copy link
Collaborator

joe-watkins commented Mar 5, 2024

Hi @mgifford Hope you've been well! Yes, this pattern could have a live region to help communicate the change. The field type change from the text to password is another programmatic mechanism but that is not as real-time as a live container. The accessible name for the checkbox is also updated upon interaction but screen reader users must move away and back to that to hear that update.

I'm not a huge fan of the content being in the CSS layer so maybe I'll create another option with a button instead of a checkbox, bring state out of the CSS, and introduce a live region. Thanks for the inspiration - I was just speaking to a colleague about this pattern. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants