Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Adding a mergify configuration for the scala steward PRs #301

Open
TonioGela opened this issue Jun 4, 2024 · 3 comments
Open

Comments

@TonioGela
Copy link
Member

The title is pretty self-explanatory. Given that most of the work on this repo nowadays is just merging the Scala Steward PRs, I propose to automatise also this step, as there's no added value in requesting human intervention (IMHO). WDYT?

@armanbilge
Copy link
Member

as there's no added value in requesting human intervention

The tlBaseVersion should be bumped depending on the last published tag and what kind of dependency bump is happening. I think its worthwhile to automate this.

@TonioGela
Copy link
Member Author

as there's no added value in requesting human intervention

The tlBaseVersion should be bumped depending on the last published tag and what kind of dependency bump is happening. I think its worthwhile to automate this.

I'm not sure I follow, we're always releasing manually, how can we screw up the baseVersion?

@armanbilge
Copy link
Member

how can we screw up the baseVersion?

The correct time to bump the base version is in the PR that makes the bump-worthy change. If you are bumping just prior to releasing, you are not following the spirit of the base version.

Further reading:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants