-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Whole channel" button from topic narrows #1040
Comments
I've implemented the "Whole channel" button within the MessageListAppBarTitle for the TopicNarrow. Here's a brief overview of the approach I've taken: In the TopicNarrow case of the MessageListAppBarTitle component, I'm currently returning a Row that includes: An IconButton (currently with an "up" arrow icon) to navigate to the enclosing channel view.
output:- Could you confirm if this approach aligns with the design intent for navigating to the enclosing stream/channel narrow? |
@gnprice @chrisbobbe can u please go through the above approach? |
@Dhanesh-Sawant If you want to share more details of what you're doing, please start a PR thread or a chat thread in #mobile-dev-help. Let's keep this issue thread clear so it's readable for discussion of the issue itself. |
This commit relocates the "up arrow" navigation button to the ZulipAppBar for a TopicNarrow, enhancing the user interface by aligning with common navigation patterns. Changes made: - An IconButton is now added directly to the actions array of ZulipAppBar when the narrow context is a TopicNarrow. - The previous method of returning a row with navigation embedded in the MessageListAppBarTitle component has been removed, simplifying the code. Fixes zulip#1040.
When viewing the message list for a topic narrow, we should have a quick way to get to the enclosing stream/channel narrow.
In the legacy zulip-mobile app, this is just a button in the app bar, with an "up" icon. In a future with a fancier app bar for these message lists (as in #1039), we may do something fancier; but for now, let's just follow the legacy app and have a button.
One update from the legacy app, though: instead of an "up" icon, let's use the "all messages" / "combined feed" icon. That's the same one that web now uses in the channel menu in the left sidebar, for the new "Go to channel feed" option.
I'm giving this the near-term "Beta 4" milestone, because when I was demoing Zulip in person a lot earlier this week, I repeatedly found the lack of it awkward. (Specifically the use case was that I was viewing one conversation and wanted to start a new one. There are other ways we could serve that use case; but any deeper re-imagining of that UX is a post-launch issue.)
The text was updated successfully, but these errors were encountered: