Update dependencies for Ruby 3.0 fixes #5640
Conversation
mitchellhenke
force-pushed
the
mitchellhenke/update-bootsnap
branch
2 times, most recently
from
686f0ba
to
768aa3e
Compare
| # Fix sassc sometimes segfaulting | ||
| Rails.application.config.assets.configure do |env| | ||
| env.export_concurrent = false | ||
| end |
There was a problem hiding this comment.
hopefully works? 🤷🏼
Tried updating a bunch of dependencies to see if there was some weird Ruby 3 interaction with a library, but was getting constantly getting:
Randomized with seed 50006
.........................../home/circleci/identity-idp/vendor/bundle/ruby/3.0.0/gems/sassc-2.4.0/lib/sassc/engine.rb:43: [BUG] Segmentation fault at 0x0000000000000000
ruby 3.0.3p157 (2021-11-24 revision 3fb7d2cadc) [x86_64-linux]
Happened on 3.0.2 and 3.0.3, always on rack_attack_spec.rb and finally gave up and took a suggestion from rails/sprockets#633
There was a problem hiding this comment.
I hit that segfault very often in local development I would love to see this land on main sooner
There was a problem hiding this comment.
Unfortunately didn't work :|
There was a problem hiding this comment.
There are also mentions of having the issue if both Rails.application.config.assets.precompile and app/assets/config/manifest.js are used, but we don't do that.
The other popular option is downgrading to sprockets 3.7.2, but that doesn't work for us since the 4.x line includes the keyword arguments fixes
mitchellhenke
force-pushed
the
mitchellhenke/update-bootsnap
branch
from
3f9011b
to
4b8a3a7
Compare
mitchellhenke
changed the title
mitchellhenke
force-pushed
the
mitchellhenke/update-bootsnap
branch
10 times, most recently
from
d2e531a
to
9f79378
Compare
| - tmp/cache/webpacker/last-compilation-digest-test | ||
| - tmp/cache/assets |
There was a problem hiding this comment.
curiously, these lines make it pass (though the CI run itself does not end up being meaningfully faster)
There was a problem hiding this comment.
It's confusing because sassc shouldn't even really be attempting to run while CI is running specs since we precompile and then disable webpacker compile, but it must do some kind of check against the cache that is still able to segfault if this resolves it.
mitchellhenke
force-pushed
the
mitchellhenke/update-bootsnap
branch
2 times, most recently
from
d0967df
to
0f48a78
Compare
mitchellhenke
force-pushed
the
mitchellhenke/update-bootsnap
branch
from
0f48a78
to
25759cc
Compare
CI finally passes with these changes on Ruby 3, but this PR does not include the upgrade to Ruby 3 just yet