Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage STG 97 #31534

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Storage STG 97 #31534

wants to merge 4 commits into from
+12,365 −2

Conversation

seanmcc-msft
Copy link
Member

No description provided.

@seanmcc-msft seanmcc-msft requested a review from a team as a code owner November 13, 2024 18:10
@seanmcc-msft seanmcc-msft requested review from scgbear and mario-guerra and removed request for a team November 13, 2024 18:10
@openapi-pipeline-app openapi-pipeline-app
Copy link

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Nov 13, 2024 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This is the public specs repo main branch which is not intended for iterative development.
    You must acknowledge that you understand that after this PR is merged, you won't be able to stop your changes from being published to Azure customers.
    If this is what you intend, add PublishToCustomers label to your PR.
    Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ The required check named Automated merging requirements met has failed. This is the final check that must pass. Refer to the check in the PR's 'Checks' tab for details on how to fix it and consult the aka.ms/ci-fix guide. In addition, refer to step 4 in the PR workflow diagram

@openapi-pipeline-app openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Nov 13, 2024 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Swagger Azure.Storage.Files.DataLake https://apiview.dev/Assemblies/Review/61ebcdc8908e4dc8b0ed81ac9e7fe31c?revisionId=8d63a8ca176d4e44a50f5fe3f7291af1
Swagger Microsoft.FileStorage https://apiview.dev/Assemblies/Review/a4e81fa81cae4aee9435e6d8b39e6a9f?revisionId=19e9fa54fe0e46a38fbb5c945031295b

@AzureRestAPISpecReview AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required data-plane new-api-version labels Nov 13, 2024
@tg-msft tg-msft added APIStewardshipBoard-SignedOff The Azure API Stewardship team has reviewed and approved the changes. BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. labels Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jalauzon-msft jalauzon-msft jalauzon-msft approved these changes

@tg-msft tg-msft tg-msft approved these changes

@scgbear scgbear Awaiting requested review from scgbear scgbear is a code owner automatically assigned from Azure/api-stewardship-board

@mario-guerra mario-guerra Awaiting requested review from mario-guerra mario-guerra is a code owner automatically assigned from Azure/api-stewardship-board

Assignees
No one assigned
Labels
APIStewardshipBoard-SignedOff The Azure API Stewardship team has reviewed and approved the changes. Approved-LintDiff BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required data-plane new-api-version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seanmcc-msft @tg-msft @jalauzon-msft @AzureRestAPISpecReview