theme/powerline base: cleanup and incorporate defaults #2059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaelicWizard
force-pushed
the
theme/powerline-base
branch
from
fbe3d75
to
3bad734
Compare
gaelicWizard
force-pushed
the
theme/powerline-base
branch
2 times, most recently
from
2333e92
to
f0559e8
Compare
gaelicWizard
force-pushed
the
theme/powerline-base
branch
4 times, most recently
from
47d52d0
to
5ef4b0f
Compare
- Local some variables,
- install reasonable defaults, based on `theme/powerline-plain` which doens't use the special font,
- Use `\D{fmt}` instead of `$(date +fmt)`.
Alsö:
- Use `\u` instead of `${SHORT_USER:-${USER?}}`.
- Use `if`/`then` properly.
- Lose some whitespace from prompt characters; that's what padding is for.
TODO:
- prompt character prefix/suffix support
- use variables rather than subshells...
gaelicWizard
force-pushed
the
theme/powerline-base
branch
from
b16d7ef
to
d322992
Compare
|
Hey there. Want to resolve the conflicts and have me review it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor cleanup and alsö apply defaults to most variables in the
theme/powerline.basefile. This should make no changes to any existing themes.Motivation and Context
This should allow easier modificaiton/creation of powerline-based themes, as well as reduce duplicative code in existing themes. The idea is to reduce duplicate "base" files from powerline themes.
How Has This Been Tested?
Careful layering of includes to ensure I got the right bits.
Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.