DRAFT: lib/battery: rename plugin/battery
#2085
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This plugin only provides utility functions, so it has zero cost to just being enabled. This allows us to eliminate assumptions from
lib/theme
and several themes.Motivation and Context
The plugin changes not one thing by being enabled, except providing some utility functions used by a couple of themes. Those themes, and even the
themes/base.theme.bash
file, have multiple tests to check whether the plugin is loaded or not. Moving the utility functions underlib
allows them to be used by the themes without special handling. If the user enables the theme to show the battery, then it should just work without alsö having to enable a plugin.How Has This Been Tested?
Types of changes
Checklist:
clean_files.txt
and formatted it usinglint_clean_files.sh
.