aliases/general & plugin/extract #2095
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaelicWizard
force-pushed
the
alias/general
branch
from
3f041cd
to
8d82edc
Compare
gaelicWizard
changed the title
gaelicWizard
force-pushed
the
alias/general
branch
6 times, most recently
from
f22b70d
to
ce281eb
Compare
NoahGorny
reviewed
Feb 19, 2022
| source "$BASH_IT/aliases/available/bash-it.aliases.bash" | ||
| source "$BASH_IT/aliases/available/directory.aliases.bash" |
There was a problem hiding this comment.
loading it here wont make it load it twice in case its enabled?
we can check if the alias is already enabled, and source only if its not
There was a problem hiding this comment.
This one actually confused the heck out of me. If the user disabled it, we should not load it. If the user enabled it, we don't need to load it. How can we tell? No idea.
There was a problem hiding this comment.
hmmm, I think that we should always check here if enabled, enable and source if not. If users dont want a certain alias, they should disable the general file. We can add a log here about it. I do not want to break backwards compat with this change
- use `-A` instead of `-a` for `ls`, - quote variable expansions, - don’t *assign* default expansions, - don’t alias `piano` without `pianobar`, - enable `bash-it` aliases in the default profile…
gaelicWizard
force-pushed
the
alias/general
branch
from
ce281eb
to
1671df9
Compare
|
I say we fix the autoloading issue, merge from master and try again. |
seefood
added
seems abandoned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
-Ainstead of-aforls,pianowithoutpianobar,alias/bash-itinprofile/default,aliases/directory,aliases/editor,alias/vim,xttoplugin/extractand format the file...Motivation and Context
Just trying to cut down on the miscellaneous stuff in
aliases/general...How Has This Been Tested?
Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.