Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BATS: shfmt #2106

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

BATS: shfmt #2106

wants to merge 11 commits into from

Conversation

gaelicWizard
Copy link
Contributor

@gaelicWizard gaelicWizard commented Mar 4, 2022 •
edited
Loading

Description

shfmt -w test/*.bash test/*/*.bats

Motivation and Context

Chapter 4. Just cleaning up. This is built on top of #2033.

How Has This Been Tested?

shfmt -w and test/run

Types of changes

  • Enhancement (non-breaking change which improves something)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

gaelicWizard and others added 11 commits March 4, 2022 14:17
@gaelicWizard
BATS: require shellcheck on test files
bf811cd 
BATS: add `*.bats` to `.gitattributes`
@gaelicWizard
test/lib: shellcheck
49b477e
@gaelicWizard
test/theme: shellcheck
45ab5b3 
test: don't clobber `$PATH`

BATS depends on `$PATH` somehow and if not handled properly, modifying `$PATH` breaks BATS badly. But, it doesn't seem like we have any reason to modify `$PATH` in the first place...so don't.

test/svn: don't clobber `$PATH`
test/ruby: don't clobber `$PATH`
test/search: don't clobber `$PATH`
@gaelicWizard
test/bash_it: shellcheck
99decb8
@gaelicWizard
test/completion: shellcheck
5f11a0d
@gaelicWizard
test/plugin: shellcheck
61247a1
@gaelicWizard
test/install: shellcheck
6f6a99e
@gaelicWizard
tests: add to clean_files.txt
c893be3
@gaelicWizard
test_helper: make lib loading default
93a05cc 
Make library loading overridable default for all tests, up through "seach".
@gaelicWizard
test: add new lib files to setup_libs()
810c52f
@gaelicWizard
test: shfmt
d37505b 
My apologies to future `git blame` hunters ♥
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gaelicWizard