Small Refactors

CHRISCARLON · Sep 21, 2024 · 90eb648 · 90eb648
1 parent 1d21ecd
commit 90eb648
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/.github/workflows/herding_cats_explorer_tests.yml b/.github/workflows/herding_cats_explorer_tests.yml
@@ -22,7 +22,7 @@ jobs:
       - name: Install dependencies
         run: |
           python -m pip install --upgrade pip
-          pip install pytest requests loguru pandas polars duckdb==1.0.0
+          pip install pytest requests loguru pandas polars duckdb==1.0.0 boto3
 
       - name: Create pytest.ini
         run: |

diff --git a/HerdingCats/api_endpoints.py b/HerdingCats/api_endpoints.py
@@ -30,4 +30,5 @@ class CkanDataCatalogues(Enum):
     SUBAK = "https://data.subak.org"
     HUMANITARIAN = "https://data.humdata.org"
     AFRICA = "https://open.africa"
+    CANADA_GOV = "https://search.open.canada.ca/opendata"
     # Add more default catalogues as needed...
diff --git a/HerdingCats/herding_cats.py b/HerdingCats/herding_cats.py
@@ -359,6 +359,10 @@ def catalogue_freshness(self):
         Returns a view of how many resources have been updated in the last 6 months
         as a percentage of the total number of resources, based on unique package names.
         """
+        logger.warning(
+            "This method might not work for all catalogues, and will return 0s"
+        )
+
         url = (
             self.cat_session.base_url + CkanApiPaths.CURRENT_PACKAGE_LIST_WITH_RESOURCES
         )
@@ -1291,7 +1295,7 @@ def aws_s3_data_loader(
 
 # Example usage...
 if __name__ == "__main__":
-    with CkanCatSession(CkanDataCatalogues.SUBAK) as session:
+    with CkanCatSession(CkanDataCatalogues.CANADA_GOV) as session:
         explore = CkanCatExplorer(session)
-        fresh = explore.catalogue_freshness()
+        fresh = explore.package_list_dataframe("polars")
         print(fresh)