Improved texture filling #2697

douira · 2024-08-21T01:08:35Z

Work items:

Implement better filling algorithm for transparent pixels
Handle NPOT textures by expanding them to the next POT
Rewrite atlas stitching to take advantage of POT-sized textures
Deal with textures smaller than 2^mipLevel (even if they are POT) which otherwise limit the mip level to log2(size) by either upscaling or doing something else

Prerequisite: #2666

…t and not performant. Mods should instead use FRAPI or Forge APIs to assign multiple materials to the quads in their models such that each quad only renders as the most demanding material it requires.

change injection of both mixins to not conflict by using WrapOperation, change the downgrade method to use passes, but then also add code to change the material bits' alpha cutoff parameter

remove ternary that gives different (but functionally identical) alpha cutoff parameters

…ad's UV coordinates and by sanity checking the quad against the sprite before downgrading

# Conflicts: # common/src/main/java/net/caffeinemc/mods/sodium/client/render/chunk/compile/pipeline/BlockRenderer.java

…ertexes

address review comments in the sprite contents mixin

… the average color but instead fill in transparent pixels with the color of the closest non-transparent pixel

djmrFunnyMan · 2024-08-22T23:51:29Z

If I understand correctly, this won't fix low-POT textures dropping mip levels (for example a single 4x4 texture will reduce all mip levels to 2)
Could this also be adressed? (by resizing to 16x16 or reusing mip levels)

douira added 13 commits August 12, 2024 17:58

gather translucency and transparency data on sprite contents

777db1d

hook up block renderer to check sprite contents for material downgrade

bcdadc2

cleanup unused per-quad scanning, this is likely too hard to implemen…

aa93df1

…t and not performant. Mods should instead use FRAPI or Forge APIs to assign multiple materials to the quads in their models such that each quad only renders as the most demanding material it requires.

move scanner into its own mixin,

c258eb1

change injection of both mixins to not conflict by using WrapOperation, change the downgrade method to use passes, but then also add code to change the material bits' alpha cutoff parameter

use one tenth alpha test for determining transparency,

7775259

remove ternary that gives different (but functionally identical) alpha cutoff parameters

fix issues with wrong sprite being used by using the center of the qu…

87a46c6

…ad's UV coordinates and by sanity checking the quad against the sprite before downgrading

extract quad UV validation logic into separate method

b51cdda

Merge branch 'dev' into texture-scanning-quad-downgrade

fa3e037

# Conflicts: # common/src/main/java/net/caffeinemc/mods/sodium/client/render/chunk/compile/pipeline/BlockRenderer.java

only do downgrade if quad is not translucent and there's non-opaque v…

7d2f1dc

…ertexes

restructure material downgrade in bufferQuad into a separate method,

b1656b8

address review comments in the sprite contents mixin

cleanup color unpacking

aff9e6a

add comments

b1af71d

rewrite the transparent pixel filling algorithm to not just calculate…

3e0d62b

… the average color but instead fill in transparent pixels with the color of the closest non-transparent pixel

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improved texture filling #2697

Improved texture filling #2697

douira commented Aug 21, 2024 •

edited

Loading

djmrFunnyMan commented Aug 22, 2024

Improved texture filling #2697

Are you sure you want to change the base?

Improved texture filling #2697

Conversation

douira commented Aug 21, 2024 • edited Loading

djmrFunnyMan commented Aug 22, 2024

douira commented Aug 21, 2024 •

edited

Loading