Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Fix trackViewsManually JS doc typo #3117

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

amortemousque
Copy link
Contributor

@amortemousque amortemousque commented Nov 7, 2024

Motivation

Fix trackViewsManually JS doc typo

Changes

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@amortemousque amortemousque requested a review from a team as a code owner November 7, 2024 14:41
@amortemousque amortemousque changed the title 📝 Fix trackViewsManually JS doc comment 📝 Fix trackViewsManually JS doc typo Nov 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.13%. Comparing base (406bdd1) to head (6ad46ff).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3117      +/-   ##
==========================================
- Coverage   93.69%   93.13%   -0.56%     
==========================================
  Files         279      279              
  Lines        7680     7680              
  Branches     1717     1717              
==========================================
- Hits         7196     7153      -43     
- Misses        484      527      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cit-pr-commenter bot commented Nov 7, 2024

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 161.46 KiB 161.46 KiB 0 B 0.00%
Logs 55.77 KiB 55.77 KiB 0 B 0.00%
Rum Slim 110.30 KiB 110.30 KiB 0 B 0.00%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.002 0.001 -0.000
addaction 0.047 0.031 -0.016
addtiming 0.001 0.001 -0.001
adderror 0.046 0.037 -0.009
startstopsessionreplayrecording 1.227 0.867 -0.361
startview 1.382 0.966 -0.416
logmessage 0.020 0.021 0.001
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 7.99 KiB 8.98 KiB 1019 B
addaction 39.24 KiB 40.27 KiB 1.03 KiB
addtiming 6.83 KiB 6.72 KiB -107 B
adderror 45.18 KiB 44.51 KiB -689 B
startstopsessionreplayrecording 6.03 KiB 6.18 KiB 154 B
startview 424.56 KiB 429.80 KiB 5.24 KiB
logmessage 39.82 KiB 40.75 KiB 954 B

🔗 RealWorld

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants