🐛 Use EventTarget.prototype.addEventListener instead of the method

[amortemousque]

Motivation

Use the window.EventTarget.prototype when possible to avoid wrong overrides (e.g: salesforce/lwc#1824)

Changes

• browser-sdk/packages/core/src/browser/addEventListener.ts

  Lines 131 to 132 in 91bace6

  	const listenerTarget =
  	window.EventTarget && eventTarget instanceof EventTarget ? window.EventTarget.prototype : eventTarget

• Share the the MockEventTarget to extend MockWorker and MockXhr

Testing

• Local
• Staging
• Unit
• End to end

---

I have gone over the contributing documentation.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.26%. Comparing base (406bdd1) to head (c362ac2).

Files with missing lines	Patch %	Lines
packages/core/test/emulate/mockEventTarget.ts	93.75%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3137      +/-   ##
==========================================
- Coverage   93.69%   93.26%   -0.44%     
==========================================
  Files         279      280       +1     
  Lines        7680     7673       -7     
  Branches     1717     1718       +1     
==========================================
- Hits         7196     7156      -40     
- Misses        484      517      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[amortemousque]

The addEventListener override conflicts with the leakDetection. The best way I found is to let the stopLeakDetection remove the override

[cit-pr-commenter]

Bundles Sizes Evolution

📦 Bundle Name	Base Size	Local Size	𝚫	𝚫%	Status
Rum	161.46 KiB	161.54 KiB	78 B	+0.05%	✅
Logs	55.77 KiB	55.85 KiB	78 B	+0.14%	✅
Rum Slim	110.30 KiB	110.38 KiB	78 B	+0.07%	✅
Worker	25.21 KiB	25.21 KiB	0 B	0.00%	✅

🚀 CPU Performance

Action Name	Base Average Cpu Time (ms)	Local Average Cpu Time (ms)	𝚫
addglobalcontext	0.002	0.001	-0.000
addaction	0.047	0.036	-0.011
addtiming	0.001	0.001	-0.001
adderror	0.046	0.030	-0.016
startstopsessionreplayrecording	1.227	0.808	-0.419
startview	1.382	0.991	-0.392
logmessage	0.020	0.019	-0.002

🧠 Memory Performance

Action Name	Base Consumption Memory (bytes)	Local Consumption Memory (bytes)	𝚫 (bytes)
addglobalcontext	7.99 KiB	8.68 KiB	713 B
addaction	39.24 KiB	41.82 KiB	2.58 KiB
addtiming	6.83 KiB	7.70 KiB	897 B
adderror	45.18 KiB	47.37 KiB	2.18 KiB
startstopsessionreplayrecording	6.03 KiB	8.39 KiB	2.37 KiB
startview	424.56 KiB	426.10 KiB	1.53 KiB
logmessage	39.82 KiB	40.93 KiB	1.10 KiB

🔗 RealWorld