-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test #6294
base: master
Are you sure you want to change the base?
test #6294
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 447305 Passed, 2648 Skipped, 18h 55m 22.19s Total Time ⌛ Performance Regressions vs Default Branch (1)
|
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6294) - mean (72ms) : 63, 81
. : milestone, 72,
master - mean (72ms) : 63, 81
. : milestone, 72,
section CallTarget+Inlining+NGEN
This PR (6294) - mean (1,106ms) : 1085, 1127
. : milestone, 1106,
master - mean (1,107ms) : 1082, 1132
. : milestone, 1107,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6294) - mean (108ms) : 106, 111
. : milestone, 108,
master - mean (108ms) : 105, 111
. : milestone, 108,
section CallTarget+Inlining+NGEN
This PR (6294) - mean (766ms) : 751, 781
. : milestone, 766,
master - mean (770ms) : 753, 786
. : milestone, 770,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6294) - mean (91ms) : 90, 93
. : milestone, 91,
master - mean (92ms) : 90, 94
. : milestone, 92,
section CallTarget+Inlining+NGEN
This PR (6294) - mean (722ms) : 706, 737
. : milestone, 722,
master - mean (725ms) : 709, 741
. : milestone, 725,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6294) - mean (190ms) : 186, 194
. : milestone, 190,
master - mean (191ms) : 185, 196
. : milestone, 191,
section CallTarget+Inlining+NGEN
This PR (6294) - mean (1,207ms) : 1185, 1229
. : milestone, 1207,
master - mean (1,213ms) : 1190, 1237
. : milestone, 1213,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6294) - mean (276ms) : 272, 280
. : milestone, 276,
master - mean (276ms) : 271, 280
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (6294) - mean (945ms) : 926, 963
. : milestone, 945,
master - mean (945ms) : 929, 960
. : milestone, 945,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (6294) - mean (265ms) : 261, 269
. : milestone, 265,
master - mean (265ms) : 260, 270
. : milestone, 265,
section CallTarget+Inlining+NGEN
This PR (6294) - mean (926ms) : 911, 941
. : milestone, 926,
master - mean (930ms) : 907, 952
. : milestone, 930,
|
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6294) (11.203M) : 0, 11202698
master (11.207M) : 0, 11207454
benchmarks/2.9.0 (11.033M) : 0, 11032866
section Automatic
This PR (6294) (7.058M) : 0, 7058387
master (7.213M) : 0, 7213054
benchmarks/2.9.0 (7.786M) : 0, 7785853
section Trace stats
master (7.646M) : 0, 7646289
section Manual
master (11.210M) : 0, 11209987
section Manual + Automatic
This PR (6294) (6.574M) : 0, 6573981
master (6.787M) : 0, 6786812
section DD_TRACE_ENABLED=0
master (10.192M) : 0, 10192322
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6294) (9.451M) : 0, 9450502
master (9.557M) : 0, 9557430
benchmarks/2.9.0 (9.495M) : 0, 9494821
section Automatic
This PR (6294) (6.310M) : 0, 6309796
master (6.335M) : 0, 6335118
section Trace stats
master (6.713M) : 0, 6713489
section Manual
master (9.597M) : 0, 9597235
section Manual + Automatic
This PR (6294) (5.927M) : 0, 5927323
master (5.989M) : 0, 5988836
section DD_TRACE_ENABLED=0
master (8.804M) : 0, 8803524
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (6294) (9.737M) : 0, 9737370
master (9.893M) : 0, 9892862
benchmarks/2.9.0 (10.020M) : 0, 10019592
section Automatic
This PR (6294) (6.296M) : 0, 6296486
master (6.418M) : 0, 6418372
benchmarks/2.9.0 (7.255M) : 0, 7255257
section Trace stats
master (7.033M) : 0, 7032568
section Manual
master (9.706M) : 0, 9706262
section Manual + Automatic
This PR (6294) (5.940M) : 0, 5939600
master (5.752M) : 0, 5752126
section DD_TRACE_ENABLED=0
master (9.107M) : 0, 9107420
|
Benchmarks Report for tracer 🐌Benchmarks for #6294 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉
|
Benchmark | Base Allocated | Diff Allocated | Change | Change % |
---|---|---|---|---|
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 | 41.94 KB | 41.68 KB | -256 B | -0.61% |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | WriteAndFlushEnrichedTraces |
net6.0 | 564μs | 2.19μs | 8.49μs | 0.556 | 0 | 0 | 41.59 KB |
master | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 655μs | 3.03μs | 12.1μs | 0.355 | 0 | 0 | 41.94 KB |
master | WriteAndFlushEnrichedTraces |
net472 | 857μs | 3.34μs | 13μs | 8.25 | 2.6 | 0.434 | 53.3 KB |
#6294 | WriteAndFlushEnrichedTraces |
net6.0 | 559μs | 2.69μs | 11.1μs | 0.551 | 0 | 0 | 41.56 KB |
#6294 | WriteAndFlushEnrichedTraces |
netcoreapp3.1 | 734μs | 4.16μs | 29.4μs | 0.347 | 0 | 0 | 41.68 KB |
#6294 | WriteAndFlushEnrichedTraces |
net472 | 848μs | 3.89μs | 15.6μs | 8.25 | 2.6 | 0.434 | 53.28 KB |
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | ExecuteNonQuery |
net6.0 | 1.28μs | 1.93ns | 7.49ns | 0.0141 | 0 | 0 | 1.02 KB |
master | ExecuteNonQuery |
netcoreapp3.1 | 1.86μs | 0.697ns | 2.61ns | 0.0139 | 0 | 0 | 1.02 KB |
master | ExecuteNonQuery |
net472 | 2.1μs | 2.44ns | 9.46ns | 0.156 | 0.00105 | 0 | 987 B |
#6294 | ExecuteNonQuery |
net6.0 | 1.18μs | 1.39ns | 5.38ns | 0.0142 | 0 | 0 | 1.02 KB |
#6294 | ExecuteNonQuery |
netcoreapp3.1 | 1.75μs | 2.86ns | 11.1ns | 0.0133 | 0 | 0 | 1.02 KB |
#6294 | ExecuteNonQuery |
net472 | 2.12μs | 1.35ns | 5.05ns | 0.157 | 0.00107 | 0 | 987 B |
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | CallElasticsearch |
net6.0 | 1.24μs | 0.547ns | 2.04ns | 0.0137 | 0 | 0 | 976 B |
master | CallElasticsearch |
netcoreapp3.1 | 1.56μs | 0.436ns | 1.63ns | 0.0133 | 0 | 0 | 976 B |
master | CallElasticsearch |
net472 | 2.45μs | 1.73ns | 6.68ns | 0.157 | 0 | 0 | 995 B |
master | CallElasticsearchAsync |
net6.0 | 1.25μs | 0.611ns | 2.29ns | 0.0132 | 0 | 0 | 952 B |
master | CallElasticsearchAsync |
netcoreapp3.1 | 1.66μs | 0.304ns | 1.1ns | 0.0143 | 0 | 0 | 1.02 KB |
master | CallElasticsearchAsync |
net472 | 2.64μs | 1ns | 3.75ns | 0.166 | 0 | 0 | 1.05 KB |
#6294 | CallElasticsearch |
net6.0 | 1.19μs | 0.704ns | 2.64ns | 0.0137 | 0 | 0 | 976 B |
#6294 | CallElasticsearch |
netcoreapp3.1 | 1.52μs | 0.48ns | 1.8ns | 0.013 | 0 | 0 | 976 B |
#6294 | CallElasticsearch |
net472 | 2.63μs | 1.39ns | 5.21ns | 0.157 | 0 | 0 | 995 B |
#6294 | CallElasticsearchAsync |
net6.0 | 1.37μs | 0.695ns | 2.6ns | 0.0131 | 0 | 0 | 952 B |
#6294 | CallElasticsearchAsync |
netcoreapp3.1 | 1.7μs | 0.636ns | 2.38ns | 0.0137 | 0 | 0 | 1.02 KB |
#6294 | CallElasticsearchAsync |
net472 | 2.61μs | 0.965ns | 3.61ns | 0.166 | 0 | 0 | 1.05 KB |
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | ExecuteAsync |
net6.0 | 1.33μs | 0.622ns | 2.41ns | 0.0133 | 0 | 0 | 952 B |
master | ExecuteAsync |
netcoreapp3.1 | 1.67μs | 0.802ns | 2.78ns | 0.0125 | 0 | 0 | 952 B |
master | ExecuteAsync |
net472 | 1.87μs | 0.696ns | 2.6ns | 0.145 | 0 | 0 | 915 B |
#6294 | ExecuteAsync |
net6.0 | 1.2μs | 0.407ns | 1.47ns | 0.0132 | 0 | 0 | 952 B |
#6294 | ExecuteAsync |
netcoreapp3.1 | 1.64μs | 0.647ns | 2.42ns | 0.0123 | 0 | 0 | 952 B |
#6294 | ExecuteAsync |
net472 | 1.85μs | 0.453ns | 1.7ns | 0.145 | 0 | 0 | 915 B |
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | SendAsync |
net6.0 | 4.65μs | 12.1ns | 46.7ns | 0.0317 | 0 | 0 | 2.31 KB |
master | SendAsync |
netcoreapp3.1 | 5.19μs | 1.71ns | 6.64ns | 0.0392 | 0 | 0 | 2.85 KB |
master | SendAsync |
net472 | 7.41μs | 1.13ns | 4.38ns | 0.495 | 0 | 0 | 3.12 KB |
#6294 | SendAsync |
net6.0 | 4.34μs | 2.95ns | 11.4ns | 0.0325 | 0 | 0 | 2.31 KB |
#6294 | SendAsync |
netcoreapp3.1 | 5.2μs | 1.78ns | 6.65ns | 0.0364 | 0 | 0 | 2.85 KB |
#6294 | SendAsync |
net472 | 7.29μs | 1.23ns | 4.6ns | 0.493 | 0 | 0 | 3.12 KB |
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 1.48μs | 0.696ns | 2.7ns | 0.0231 | 0 | 0 | 1.64 KB |
master | EnrichedLog |
netcoreapp3.1 | 2.21μs | 0.916ns | 3.55ns | 0.0223 | 0 | 0 | 1.64 KB |
master | EnrichedLog |
net472 | 2.44μs | 1.09ns | 4.09ns | 0.249 | 0 | 0 | 1.57 KB |
#6294 | EnrichedLog |
net6.0 | 1.5μs | 1.27ns | 4.74ns | 0.0233 | 0 | 0 | 1.64 KB |
#6294 | EnrichedLog |
netcoreapp3.1 | 2.05μs | 1.25ns | 4.84ns | 0.0227 | 0 | 0 | 1.64 KB |
#6294 | EnrichedLog |
net472 | 2.55μs | 1.48ns | 5.75ns | 0.25 | 0 | 0 | 1.57 KB |
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 120μs | 69.8ns | 261ns | 0 | 0 | 0 | 4.28 KB |
master | EnrichedLog |
netcoreapp3.1 | 124μs | 195ns | 756ns | 0.0625 | 0 | 0 | 4.28 KB |
master | EnrichedLog |
net472 | 152μs | 97.6ns | 365ns | 0.682 | 0.227 | 0 | 4.46 KB |
#6294 | EnrichedLog |
net6.0 | 120μs | 122ns | 455ns | 0.06 | 0 | 0 | 4.28 KB |
#6294 | EnrichedLog |
netcoreapp3.1 | 125μs | 164ns | 634ns | 0 | 0 | 0 | 4.28 KB |
#6294 | EnrichedLog |
net472 | 152μs | 159ns | 617ns | 0.684 | 0.228 | 0 | 4.46 KB |
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 2.87μs | 0.804ns | 3.01ns | 0.0301 | 0 | 0 | 2.2 KB |
master | EnrichedLog |
netcoreapp3.1 | 4.12μs | 1.51ns | 5.66ns | 0.0288 | 0 | 0 | 2.2 KB |
master | EnrichedLog |
net472 | 5.05μs | 1.24ns | 4.63ns | 0.319 | 0 | 0 | 2.02 KB |
#6294 | EnrichedLog |
net6.0 | 2.93μs | 1.22ns | 4.73ns | 0.0306 | 0 | 0 | 2.2 KB |
#6294 | EnrichedLog |
netcoreapp3.1 | 4.41μs | 2.07ns | 8.01ns | 0.0286 | 0 | 0 | 2.2 KB |
#6294 | EnrichedLog |
net472 | 4.86μs | 2.12ns | 8.2ns | 0.32 | 0 | 0 | 2.02 KB |
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | SendReceive |
net6.0 | 1.39μs | 0.645ns | 2.5ns | 0.016 | 0 | 0 | 1.14 KB |
master | SendReceive |
netcoreapp3.1 | 1.74μs | 0.55ns | 2.06ns | 0.0156 | 0 | 0 | 1.14 KB |
master | SendReceive |
net472 | 2.06μs | 0.378ns | 1.36ns | 0.183 | 0 | 0 | 1.16 KB |
#6294 | SendReceive |
net6.0 | 1.44μs | 0.606ns | 2.27ns | 0.0159 | 0 | 0 | 1.14 KB |
#6294 | SendReceive |
netcoreapp3.1 | 1.7μs | 0.839ns | 3.25ns | 0.0153 | 0 | 0 | 1.14 KB |
#6294 | SendReceive |
net472 | 2.15μs | 2.08ns | 7.8ns | 0.183 | 0 | 0 | 1.16 KB |
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | EnrichedLog |
net6.0 | 2.76μs | 0.874ns | 3.27ns | 0.0222 | 0 | 0 | 1.6 KB |
master | EnrichedLog |
netcoreapp3.1 | 4μs | 2.93ns | 11.3ns | 0.0219 | 0 | 0 | 1.65 KB |
master | EnrichedLog |
net472 | 4.39μs | 2.15ns | 8.05ns | 0.324 | 0 | 0 | 2.04 KB |
#6294 | EnrichedLog |
net6.0 | 2.76μs | 0.969ns | 3.75ns | 0.0219 | 0 | 0 | 1.6 KB |
#6294 | EnrichedLog |
netcoreapp3.1 | 3.9μs | 1.82ns | 7.04ns | 0.0215 | 0 | 0 | 1.65 KB |
#6294 | EnrichedLog |
net472 | 4.5μs | 2.34ns | 9.08ns | 0.322 | 0 | 0 | 2.04 KB |
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️
Faster 🎉 in #6294
Benchmark
base/diff
Base Median (ns)
Diff Median (ns)
Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1
1.141
768.55
673.38
Benchmark | base/diff | Base Median (ns) | Diff Median (ns) | Modality |
---|---|---|---|---|
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 | 1.141 | 768.55 | 673.38 |
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | StartFinishSpan |
net6.0 | 405ns | 0.283ns | 1.1ns | 0.00804 | 0 | 0 | 576 B |
master | StartFinishSpan |
netcoreapp3.1 | 544ns | 0.659ns | 2.55ns | 0.00758 | 0 | 0 | 576 B |
master | StartFinishSpan |
net472 | 648ns | 0.852ns | 3.3ns | 0.0917 | 0 | 0 | 578 B |
master | StartFinishScope |
net6.0 | 567ns | 0.41ns | 1.59ns | 0.0097 | 0 | 0 | 696 B |
master | StartFinishScope |
netcoreapp3.1 | 768ns | 0.827ns | 3.2ns | 0.00937 | 0 | 0 | 696 B |
master | StartFinishScope |
net472 | 895ns | 0.915ns | 3.54ns | 0.104 | 0 | 0 | 658 B |
#6294 | StartFinishSpan |
net6.0 | 401ns | 0.584ns | 2.26ns | 0.00804 | 0 | 0 | 576 B |
#6294 | StartFinishSpan |
netcoreapp3.1 | 585ns | 0.938ns | 3.63ns | 0.00798 | 0 | 0 | 576 B |
#6294 | StartFinishSpan |
net472 | 688ns | 0.738ns | 2.86ns | 0.0916 | 0 | 0 | 578 B |
#6294 | StartFinishScope |
net6.0 | 556ns | 0.483ns | 1.87ns | 0.00979 | 0 | 0 | 696 B |
#6294 | StartFinishScope |
netcoreapp3.1 | 672ns | 0.867ns | 3.36ns | 0.00925 | 0 | 0 | 696 B |
#6294 | StartFinishScope |
net472 | 887ns | 0.815ns | 3.15ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
---|---|---|---|---|---|---|---|---|---|
master | RunOnMethodBegin |
net6.0 | 648ns | 0.872ns | 3.26ns | 0.00984 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
netcoreapp3.1 | 913ns | 1.11ns | 4.29ns | 0.00921 | 0 | 0 | 696 B |
master | RunOnMethodBegin |
net472 | 1.18μs | 1.56ns | 6.06ns | 0.104 | 0 | 0 | 658 B |
#6294 | RunOnMethodBegin |
net6.0 | 673ns | 0.6ns | 2.32ns | 0.00971 | 0 | 0 | 696 B |
#6294 | RunOnMethodBegin |
netcoreapp3.1 | 888ns | 0.78ns | 3.02ns | 0.00898 | 0 | 0 | 696 B |
#6294 | RunOnMethodBegin |
net472 | 1.1μs | 1.16ns | 4.49ns | 0.104 | 0 | 0 | 658 B |
Summary of changes
Reason for change
Implementation details
Test coverage
Other details