[ASM] iast: Fix `Microsoft.Data.Sqlite` database tainting #6295

e-n-0 · 2024-11-15T15:18:06Z

Summary of changes

The instrumentation introduced for tainting values coming from database was incorrect for Microsoft.Data.Sqlite.
A typo was introduced in the name Microsoft.Data.Sqlite.SqliteDataReader, thus making the instrumentation fail.

Test coverage

Tests on database tainting such as Stored XSS or Stored SQLI has been updated to also create an SQLite connection using Microsoft.Data.Sqlite while also keeping the System.Data.SQLite connection.

Other details

Original implementation PR: #5804

github-actions · 2024-11-15T15:18:53Z

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer.
The diff is simplistic, so please check some files anyway while we improve it.

1 occurrences of :

-      http.url: http://localhost:00000/Iast/StoredSqli,
+      http.url: http://localhost:00000/Iast/StoredSqli?useMicrosoftDataDb=...,

1 occurrences of :

-      http.url: http://localhost:00000/Iast/StoredXss?param=%3Cb%3ERawValue%3C/b%3E,
+      http.url: http://localhost:00000/Iast/StoredXss?param=%3Cb%3ERawValue%3C/b%3E&useMicrosoftDataDb=...,

1 occurrences of :

-      http.url: http://localhost:00000/Iast/StoredXssEscaped,
+      http.url: http://localhost:00000/Iast/StoredXssEscaped?useMicrosoftDataDb=...,

andrewlock · 2024-11-15T15:49:38Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6295) - mean (73ms)  : 64, 81
     .   : milestone, 73,
    master - mean (72ms)  : 63, 81
     .   : milestone, 72,

    section CallTarget+Inlining+NGEN
    This PR (6295) - mean (1,110ms)  : 1086, 1134
     .   : milestone, 1110,
    master - mean (1,107ms)  : 1082, 1132
     .   : milestone, 1107,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6295) - mean (110ms)  : 106, 113
     .   : milestone, 110,
    master - mean (108ms)  : 105, 111
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6295) - mean (769ms)  : 753, 785
     .   : milestone, 769,
    master - mean (770ms)  : 753, 786
     .   : milestone, 770,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6295) - mean (93ms)  : 90, 95
     .   : milestone, 93,
    master - mean (92ms)  : 90, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (6295) - mean (723ms)  : 708, 738
     .   : milestone, 723,
    master - mean (725ms)  : 709, 741
     .   : milestone, 725,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6295) - mean (191ms)  : 186, 195
     .   : milestone, 191,
    master - mean (191ms)  : 185, 196
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6295) - mean (1,210ms)  : 1181, 1240
     .   : milestone, 1210,
    master - mean (1,213ms)  : 1190, 1237
     .   : milestone, 1213,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6295) - mean (277ms)  : 273, 281
     .   : milestone, 277,
    master - mean (276ms)  : 271, 280
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6295) - mean (942ms)  : 925, 959
     .   : milestone, 942,
    master - mean (945ms)  : 929, 960
     .   : milestone, 945,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6295) - mean (265ms)  : 262, 268
     .   : milestone, 265,
    master - mean (265ms)  : 260, 270
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (6295) - mean (925ms)  : 906, 943
     .   : milestone, 925,
    master - mean (930ms)  : 907, 952
     .   : milestone, 930,

datadog-ddstaging · 2024-11-15T16:26:17Z

Datadog Report

Branch report: flavien/iast/ef_fix
Commit report: 9411f11
Test service: dd-trace-dotnet

❌ 15 Failed (0 Known Flaky), 453631 Passed, 2732 Skipped, 18h 41m 22.08s Total Time

❌ Failed Tests (15)

This report shows up to 5 failed tests.

AllCycleMoreComplexBody - Benchmarks.Trace.Asm.AppSecBodyBenchmark - Details
AllCycleMoreComplexBody - Benchmarks.Trace.Asm.AppSecBodyBenchmark - Details
AllCycleMoreComplexBody - Benchmarks.Trace.Asm.AppSecBodyBenchmark - Details
AllCycleSimpleBody - Benchmarks.Trace.Asm.AppSecBodyBenchmark - Details
AllCycleSimpleBody - Benchmarks.Trace.Asm.AppSecBodyBenchmark - Details

andrewlock · 2024-11-15T16:58:42Z

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6295) (11.032M)   : 0, 11032468
    master (11.197M)   : 0, 11197381
    benchmarks/2.9.0 (11.033M)   : 0, 11032866

    section Automatic
    This PR (6295) (7.074M)   : 0, 7074491
    master (7.192M)   : 0, 7192384
    benchmarks/2.9.0 (7.786M)   : 0, 7785853

    section Trace stats
    master (7.476M)   : 0, 7475872

    section Manual
    master (11.271M)   : 0, 11270878

    section Manual + Automatic
    This PR (6295) (6.524M)   : 0, 6524324
    master (6.621M)   : 0, 6620931

    section DD_TRACE_ENABLED=0
    master (10.177M)   : 0, 10176556

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6295) (9.599M)   : 0, 9599024
    master (9.640M)   : 0, 9639769
    benchmarks/2.9.0 (9.495M)   : 0, 9494821

    section Automatic
    This PR (6295) (6.469M)   : 0, 6469496
    master (6.385M)   : 0, 6384570

    section Trace stats
    master (6.740M)   : 0, 6739552

    section Manual
    master (9.612M)   : 0, 9611974

    section Manual + Automatic
    This PR (6295) (6.004M)   : 0, 6004356
    master (5.891M)   : 0, 5890550

    section DD_TRACE_ENABLED=0
    master (8.839M)   : 0, 8838985

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (6295) (9.823M)   : 0, 9823139
    master (10.121M)   : 0, 10120763
    benchmarks/2.9.0 (10.020M)   : 0, 10019592

    section Automatic
    This PR (6295) (6.370M)   : 0, 6370164
    master (6.469M)   : 0, 6469072
    benchmarks/2.9.0 (7.255M)   : 0, 7255257

    section Trace stats
    master (6.864M)   : 0, 6863851

    section Manual
    master (9.854M)   : 0, 9854162

    section Manual + Automatic
    This PR (6295) (5.949M)   : 0, 5949205
    master (5.906M)   : 0, 5906154

    section DD_TRACE_ENABLED=0
    master (9.224M)   : 0, 9224050

daniel-romano-DD

Good catch. Thanks a lot

andrewlock · 2024-11-16T00:11:35Z

Benchmarks Report for tracer 🐌

Benchmarks for #6295 compared to master:

3 benchmarks are faster, with geometric mean 1.163
1 benchmarks are slower, with geometric mean 1.130
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	7.95μs	43.2ns	245ns	0.0149	0.00746	0	5.61 KB
master	`StartStopWithChild`	netcoreapp3.1	9.93μs	56ns	367ns	0.0196	0.00981	0	5.8 KB
master	`StartStopWithChild`	net472	16.5μs	43.4ns	168ns	1.07	0.342	0.0894	6.21 KB
#6295	`StartStopWithChild`	net6.0	7.81μs	43.7ns	283ns	0.0152	0.00759	0	5.61 KB
#6295	`StartStopWithChild`	netcoreapp3.1	10.1μs	50ns	240ns	0.0243	0.00974	0	5.8 KB
#6295	`StartStopWithChild`	net472	16.4μs	56.7ns	204ns	1.05	0.329	0.0987	6.22 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	507μs	240ns	930ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	644μs	270ns	1.01μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	858μs	288ns	1.04μs	0.428	3.3 KB
#6295	`WriteAndFlushEnrichedTraces`	net6.0	505μs	232ns	899ns	0	2.7 KB
#6295	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	634μs	402ns	1.39μs	0	2.7 KB
#6295	`WriteAndFlushEnrichedTraces`	net472	870μs	1.62μs	6.27μs	0.434	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	198μs	1.09μs	7.31μs	0.201	18.73 KB
master	`SendRequest`	netcoreapp3.1	215μs	1.22μs	9.23μs	0.217	20.89 KB
master	`SendRequest`	net472	0.00176ns	0.000556ns	0.00215ns	0	0 b
#6295	`SendRequest`	net6.0	199μs	1.14μs	8.78μs	0.196	18.73 KB
#6295	`SendRequest`	netcoreapp3.1	222μs	1.18μs	8.25μs	0.218	20.89 KB
#6295	`SendRequest`	net472	0.000763ns	0.000313ns	0.00117ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	585μs	2.74μs	10.2μs	0.566	0	0	41.72 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	674μs	2.36μs	9.13μs	0.331	0	0	41.63 KB
master	`WriteAndFlushEnrichedTraces`	net472	853μs	4.17μs	18.7μs	8.19	2.59	0.431	53.26 KB
#6295	`WriteAndFlushEnrichedTraces`	net6.0	571μs	2.6μs	10.1μs	0.561	0	0	41.59 KB
#6295	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	669μs	3.35μs	14.2μs	0.327	0	0	41.63 KB
#6295	`WriteAndFlushEnrichedTraces`	net472	885μs	2.9μs	11.2μs	8.04	2.23	0.446	53.32 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.29μs	1.17ns	4.54ns	0.0142	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.78μs	1.19ns	4.6ns	0.0133	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.1μs	0.779ns	3.02ns	0.156	0.00105	987 B
#6295	`ExecuteNonQuery`	net6.0	1.33μs	1.18ns	4.58ns	0.0141	0	1.02 KB
#6295	`ExecuteNonQuery`	netcoreapp3.1	1.75μs	1.01ns	3.93ns	0.014	0	1.02 KB
#6295	`ExecuteNonQuery`	net472	2.06μs	1.33ns	4.97ns	0.156	0.00103	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6295

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑net6.0	1.115	1,302.84	1,168.50

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.3μs	0.582ns	2.18ns	0.0137	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.58μs	2.2ns	7.94ns	0.0132	976 B
master	`CallElasticsearch`	net472	2.61μs	1.12ns	4.19ns	0.157	995 B
master	`CallElasticsearchAsync`	net6.0	1.21μs	0.535ns	1.93ns	0.0133	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.64μs	0.892ns	3.34ns	0.014	1.02 KB
master	`CallElasticsearchAsync`	net472	2.59μs	1.59ns	6.16ns	0.167	1.05 KB
#6295	`CallElasticsearch`	net6.0	1.17μs	0.411ns	1.54ns	0.0135	976 B
#6295	`CallElasticsearch`	netcoreapp3.1	1.53μs	0.783ns	2.93ns	0.0128	976 B
#6295	`CallElasticsearch`	net472	2.58μs	1.33ns	5.13ns	0.158	995 B
#6295	`CallElasticsearchAsync`	net6.0	1.28μs	0.501ns	1.88ns	0.0136	952 B
#6295	`CallElasticsearchAsync`	netcoreapp3.1	1.63μs	0.476ns	1.72ns	0.0139	1.02 KB
#6295	`CallElasticsearchAsync`	net472	2.67μs	1.33ns	4.99ns	0.166	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6295

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0	1.130	1,218.44	1,376.52

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.22μs	0.382ns	1.43ns	0.0136	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.57μs	1.31ns	5.08ns	0.0134	952 B
master	`ExecuteAsync`	net472	1.85μs	2.49ns	9.66ns	0.145	915 B
#6295	`ExecuteAsync`	net6.0	1.38μs	0.724ns	2.71ns	0.013	952 B
#6295	`ExecuteAsync`	netcoreapp3.1	1.71μs	1.5ns	5.41ns	0.0127	952 B
#6295	`ExecuteAsync`	net472	1.89μs	0.982ns	3.8ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.31μs	1.01ns	3.63ns	0.0316	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.4μs	4.82ns	18.7ns	0.0377	2.85 KB
master	`SendAsync`	net472	7.4μs	2.02ns	7.83ns	0.496	3.12 KB
#6295	`SendAsync`	net6.0	4.31μs	1.4ns	5.23ns	0.0324	2.31 KB
#6295	`SendAsync`	netcoreapp3.1	5.33μs	4.03ns	15.6ns	0.0374	2.85 KB
#6295	`SendAsync`	net472	7.36μs	1.71ns	6.39ns	0.494	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.56μs	0.656ns	2.54ns	0.0233	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.23μs	0.808ns	3.13ns	0.0221	1.64 KB
master	`EnrichedLog`	net472	2.67μs	1.88ns	7.28ns	0.249	1.57 KB
#6295	`EnrichedLog`	net6.0	1.48μs	1.17ns	4.53ns	0.023	1.64 KB
#6295	`EnrichedLog`	netcoreapp3.1	2.22μs	0.633ns	2.28ns	0.0221	1.64 KB
#6295	`EnrichedLog`	net472	2.51μs	1.36ns	5.26ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	119μs	144ns	556ns	0.0587	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	124μs	151ns	585ns	0	0	4.28 KB
master	`EnrichedLog`	net472	152μs	95.8ns	371ns	0.683	0.228	4.46 KB
#6295	`EnrichedLog`	net6.0	119μs	361ns	1.4μs	0.0612	0	4.28 KB
#6295	`EnrichedLog`	netcoreapp3.1	123μs	153ns	591ns	0	0	4.28 KB
#6295	`EnrichedLog`	net472	150μs	202ns	782ns	0.683	0.228	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.1μs	0.94ns	3.64ns	0.0311	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.12μs	3ns	11.6ns	0.0286	2.2 KB
master	`EnrichedLog`	net472	4.82μs	1.33ns	4.98ns	0.319	2.02 KB
#6295	`EnrichedLog`	net6.0	3.02μs	1.08ns	4.17ns	0.0302	2.2 KB
#6295	`EnrichedLog`	netcoreapp3.1	4.28μs	1.52ns	5.69ns	0.0283	2.2 KB
#6295	`EnrichedLog`	net472	4.82μs	1.47ns	5.49ns	0.319	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.35μs	0.681ns	2.64ns	0.0162	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.77μs	2.44ns	9.46ns	0.0153	1.14 KB
master	`SendReceive`	net472	2.03μs	1.47ns	5.7ns	0.183	1.16 KB
#6295	`SendReceive`	net6.0	1.35μs	0.564ns	2.03ns	0.0162	1.14 KB
#6295	`SendReceive`	netcoreapp3.1	1.75μs	1.29ns	4.99ns	0.0158	1.14 KB
#6295	`SendReceive`	net472	2.11μs	2.81ns	10.9ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.73μs	0.684ns	2.65ns	0.0219	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.95μs	2.19ns	8.49ns	0.0218	1.65 KB
master	`EnrichedLog`	net472	4.47μs	2.07ns	7.76ns	0.322	2.04 KB
#6295	`EnrichedLog`	net6.0	2.9μs	1.03ns	3.86ns	0.0217	1.6 KB
#6295	`EnrichedLog`	netcoreapp3.1	3.88μs	1.94ns	7.26ns	0.0215	1.65 KB
#6295	`EnrichedLog`	net472	4.37μs	2.46ns	9.52ns	0.322	2.04 KB

Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6295

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0	1.196	576.22	481.85
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0	1.180	465.83	394.86

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	466ns	0.378ns	1.46ns	0.00815	576 B
master	`StartFinishSpan`	netcoreapp3.1	557ns	0.32ns	1.15ns	0.00781	576 B
master	`StartFinishSpan`	net472	605ns	0.514ns	1.99ns	0.0917	578 B
master	`StartFinishScope`	net6.0	576ns	0.471ns	1.82ns	0.00984	696 B
master	`StartFinishScope`	netcoreapp3.1	708ns	0.97ns	3.76ns	0.00927	696 B
master	`StartFinishScope`	net472	920ns	0.712ns	2.76ns	0.104	658 B
#6295	`StartFinishSpan`	net6.0	394ns	0.354ns	1.37ns	0.00816	576 B
#6295	`StartFinishSpan`	netcoreapp3.1	546ns	0.74ns	2.87ns	0.00768	576 B
#6295	`StartFinishSpan`	net472	628ns	1.19ns	4.61ns	0.0917	578 B
#6295	`StartFinishScope`	net6.0	482ns	0.403ns	1.56ns	0.00965	696 B
#6295	`StartFinishScope`	netcoreapp3.1	722ns	1.39ns	5.38ns	0.00937	696 B
#6295	`StartFinishScope`	net472	880ns	1.01ns	3.64ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	645ns	0.482ns	1.87ns	0.00977	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	880ns	0.617ns	2.23ns	0.00929	696 B
master	`RunOnMethodBegin`	net472	1.21μs	1.17ns	4.52ns	0.105	658 B
#6295	`RunOnMethodBegin`	net6.0	612ns	0.632ns	2.28ns	0.00975	696 B
#6295	`RunOnMethodBegin`	netcoreapp3.1	953ns	0.694ns	2.69ns	0.00912	696 B
#6295	`RunOnMethodBegin`	net472	1.15μs	0.859ns	3.33ns	0.104	658 B

e-n-0 requested review from a team as code owners November 15, 2024 15:18

github-actions bot added the area:asm label Nov 15, 2024

Fix

9411f11

e-n-0 force-pushed the flavien/iast/ef_fix branch from 86e5c95 to 9411f11 Compare November 15, 2024 17:15

e-n-0 changed the title ~~[ASM] Fix Microsoft.Data.Sqlite database tainting~~ [ASM] iast: Fix Microsoft.Data.Sqlite database tainting Nov 15, 2024

daniel-romano-DD approved these changes Nov 15, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ASM] iast: Fix `Microsoft.Data.Sqlite` database tainting #6295

[ASM] iast: Fix `Microsoft.Data.Sqlite` database tainting #6295

e-n-0 commented Nov 15, 2024 •

edited

Loading

github-actions bot commented Nov 15, 2024

andrewlock commented Nov 15, 2024 •

edited

Loading

datadog-ddstaging bot commented Nov 15, 2024 •

edited

Loading

andrewlock commented Nov 15, 2024 •

edited

Loading

daniel-romano-DD left a comment

andrewlock commented Nov 16, 2024

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6295

Raw results

Slower ⚠️ in #6295

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6295

Raw results

Raw results

[ASM] iast: Fix Microsoft.Data.Sqlite database tainting #6295

Are you sure you want to change the base?

[ASM] iast: Fix Microsoft.Data.Sqlite database tainting #6295

Conversation

e-n-0 commented Nov 15, 2024 • edited Loading

Summary of changes

Test coverage

Other details

github-actions bot commented Nov 15, 2024

Snapshots difference summary

andrewlock commented Nov 15, 2024 • edited Loading

Execution-Time Benchmarks Report ⏱️

datadog-ddstaging bot commented Nov 15, 2024 • edited Loading

Datadog Report

❌ Failed Tests (15)

andrewlock commented Nov 15, 2024 • edited Loading

Throughput/Crank Report ⚡

daniel-romano-DD left a comment

Choose a reason for hiding this comment

andrewlock commented Nov 16, 2024

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6295

Raw results

Slower ⚠️ in #6295

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Faster 🎉 in #6295

Raw results

Raw results

[ASM] iast: Fix `Microsoft.Data.Sqlite` database tainting #6295

[ASM] iast: Fix `Microsoft.Data.Sqlite` database tainting #6295

e-n-0 commented Nov 15, 2024 •

edited

Loading

andrewlock commented Nov 15, 2024 •

edited

Loading

datadog-ddstaging bot commented Nov 15, 2024 •

edited

Loading

andrewlock commented Nov 15, 2024 •

edited

Loading