Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use guess-next-dev instead of release-branch-semver [2.17] #11409

Open
wants to merge 1 commit into
base: 2.17
Choose a base branch
from

Conversation

erikayasuda
Copy link
Contributor

@erikayasuda erikayasuda commented Nov 14, 2024

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@erikayasuda erikayasuda requested a review from a team as a code owner November 14, 2024 14:58
@erikayasuda erikayasuda added the changelog/no-changelog A changelog entry is not required for this PR. label Nov 14, 2024
Copy link
Contributor

CODEOWNERS have been resolved as:

pyproject.toml                                                          @DataDog/python-guild

@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: erikayasuda/guess-next-dev
Commit report: cc99b97
Test service: dd-trace-py

✅ 0 Failed, 1286 Passed, 0 Skipped, 32m 6.53s Total duration (6m 26.99s time saved)

@pr-commenter
Copy link

pr-commenter bot commented Nov 14, 2024

Benchmarks

Benchmark execution time: 2024-11-14 15:38:06

Comparing candidate commit cc99b97 in PR branch erikayasuda/guess-next-dev with baseline commit 4f7052e in branch 2.17.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 382 metrics, 2 unstable metrics.

@erikayasuda
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 15, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-15 14:14:59 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-11-15 14:15:03 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-11-15 14:34:31 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in 2.17 is 0s.


2024-11-15 16:35:16 UTCMergeQueue: The build pipeline has timeout

The merge request has been interrupted because the build took longer than expected. The current limit for the base branch '2.17' is 120 minutes.

Possible reasons:

  • some mandatory checkruns are failing:
    • Validate changelog
    • require-checklist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. mergequeue-status: rejected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants