Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(profiling): fix sanitizers on Linux #11424

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

sanchda
Copy link
Contributor

@sanchda sanchda commented Nov 15, 2024

In order for our tests to work with sanitizers,

  • sanitizer lib needs to be propagated from the test fixture to the dynamic libraries (e.g., dd_wrapper) (this was broken due to underspecifying the link type)
  • dynamic linker needs to be able to find the .so; the way we did it worked OK on macos, but on Linux the libs are actually in a subdir

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@sanchda sanchda requested a review from a team as a code owner November 15, 2024 18:31
Copy link
Contributor

CODEOWNERS have been resolved as:

ddtrace/internal/datadog/profiling/cmake/AnalysisFunc.cmake             @DataDog/profiling-python

@taegyunkim taegyunkim added changelog/no-changelog A changelog entry is not required for this PR. Profiling Continous Profling labels Nov 15, 2024
@sanchda sanchda enabled auto-merge (squash) November 15, 2024 18:38
@pr-commenter
Copy link

pr-commenter bot commented Nov 15, 2024

Benchmarks

Benchmark execution time: 2024-11-15 19:08:58

Comparing candidate commit d5cf3ec in PR branch sanchda/fix_libsan with baseline commit 1aaed62 in branch main.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 387 metrics, 2 unstable metrics.

scenario:iast_aspects-ospathnormcase_aspect

  • 🟩 execution_time [-237.066ns; -213.574ns] or [-8.868%; -7.989%]

@sanchda sanchda closed this Nov 15, 2024
auto-merge was automatically disabled November 15, 2024 21:06

Pull request was closed

@sanchda sanchda reopened this Nov 15, 2024
@sanchda
Copy link
Contributor Author

sanchda commented Nov 15, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 15, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-15 21:07:13 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!


2024-11-15 21:07:17 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

Use /merge -c to cancel this operation!


⏳ command still in progress ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. mergequeue-status: waiting Profiling Continous Profling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants