Migrate deepl-test-app to JUnit 5 #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParanoidUser
changed the title
|
@JanEbbing, this pull request has been sitting here for a while. Are there any feedback points that need to be addressed before it can be approved for merging? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ahoy, @JanEbbing! 👋
The integration test in the sample project is based on the older JUnit 4. This PR migrates it to JUnit 5.10.0 to be in sync with the main project. I think the Maven profiles
buildProject/runIntegrationTestscan also be eliminated in favor of the more universalmvn package -DskipTests. Look forward to hearing what you think.