Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add analysis "detail" and audit history ("comments") to project findi… #3183

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KevinHodder
Copy link

Add analysis "detail" and audit history ("comments") to project findings API response

Description

Add analysis "detail" and audit history ("comments") to project findings API response
This is very useful when generating reports from the DepTrack data.

Addressed Issue

adds the feature required to close #2573
Extends the Finding Packaging Format in a backward compatible way.

Additional Details

Adds the required column for the "detail" to the DB query, and appends detail and comments (already available via the Analysis class) to the returned findings object.
Went for minimal changes, as consistent with previous changes as possible.

Checklist

  • I have read and understand the contributing guidelines
    - [ ] This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
    - [ ] This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include Audit Trail and Details in FPF export
1 participant