-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce "collection" projects for better usage of hierarchical view #2041 #658
base: master
Are you sure you want to change the base?
Introduce "collection" projects for better usage of hierarchical view #2041 #658
Conversation
This is a feature I would love to see in dependencytrack. Would certainly make it easier to structure projects and see the issues at a glance. @nscuro Is there anything left todo to be able to merge this pr and the corresponding backend pr? |
9c6d94c
to
c490bf6
Compare
Warning: I fixed a lot of conflicts and did not have time to test it. Will try to find time tomorrow to test it. Furthermore I threw out my bugfix for the double loading logic as @nscuro already did another fix for this |
[deleted - belonged to backend] |
Should be good to go :) |
@nscuro do I need to do something for the failed checks? the i18n issues don't seem to be from my changes, and the other Linter I don't see where I can find the actual output of whats wrong, only the files it complains about. |
@rkg-mm any plans to get this merged? |
Yes I would prefer to have it merged asap, but since I had to wait a while I got now in a timeframe where I lack time to implement the Feedback, not sure if I can finish this soon. If anyone wants to help feel free to raise PRs to my branch and I can integrate changes. Otherwise I fear this will need to wait a bit. |
I tried to look into why two checks failed, but the logs have already expired. Any idea to rerun the checks would be appreciated. |
@nscuro can you help with rerunning the checks? |
@rkg-mm Sadly it's not giving me the option to: For comparison, the option is available for a workflow that ran earlier today: I think you need to push a change (can be an empty commit) to trigger another build... |
Re-assigning to 4.13 milestone in order to reduce the pressure on contributors to get this finished whilst allowing v4.12.0 to be released quicker. |
Hello! When approximately we will be able to get this update? Thank you) |
c490bf6
to
9088f24
Compare
@nscuro can you explain how to
|
The check is failing because translations are missing for newly added i18n keys. Here's instructions on how to auto-translate: https://github.com/DependencyTrack/frontend?tab=readme-ov-file#adding-or-improving-translations
That should be the correct solution. But yeah it shouldn't modify stuff you didn't touch. What kind of changes is it doing to those files? |
It tried to change Line endings in 200 untouched files between CRLF and LF. For now I think I fixed it by rolling back all files i didn't touch and only commit the others after running prittifier, but maybe you have an idea how to fix that for next changes? |
@nscuro
I don't like any of these solutions :-( . Better ideas? |
c485402
to
fed78d8
Compare
…ject list and mark collection projects visually. Signed-off-by: Ralf King <[email protected]>
* Made project list reusable independent from the project list view * Reused project list to show children of collection projects in project view * Hide tabs without function in collection projects, show child projects instead * visually mark collection projects in project header and explain logic used in tooltip Signed-off-by: Ralf King <[email protected]>
Signed-off-by: Ralf King <[email protected]>
Signed-off-by: Ralf King <[email protected]>
Signed-off-by: Ralf King <[email protected]>
Signed-off-by: Ralf King <[email protected]>
…ption, to match latest server version. Signed-off-by: Ralf King <[email protected]>
Signed-off-by: Ralf King <[email protected]>
Signed-off-by: Ralf King <[email protected]>
Signed-off-by: Ralf King <[email protected]>
Signed-off-by: Ralf King <[email protected]>
… reloading the page) Signed-off-by: Ralf King <[email protected]>
…ERSION_CHILDREN to match new server changes Signed-off-by: Ralf King <[email protected]>
* Add frontend support for so far missing project classifiers supported by backend. * Move available classifiers & collection logics into central mixin to reduce code duplication * Ensure classifiers are always sorted the same way in all views Signed-off-by: Ralf King <[email protected]>
b8ca2c5
to
7f364bb
Compare
Signed-off-by: Ralf King <[email protected]>
fyi: a package of this PR is available at https://github.com/users/netomi/packages/container/dtrack-frontend/289602681?tag=4.13.0-SNAPSHOT ghcr.io/netomi/dtrack-frontend:4.13.0-SNAPSHOT |
Description
This change introduces UI logic for "collection projects". Those are basically projects used as parent for other projects that shall not hold any own component or vulnerability data, but instead get calculated from child projects using different configurable aggregation logics.
** Add Frontend support for other missing classifiers which are supported by backend already since 2023
** Move available classifiers into mixin to reduce code duplication & ensure classifier dropdown list is sorted identical in all views
** Fixes some routing bugs
Required Backend PR: DependencyTrack/dependency-track#3258
Addressed Issue
DependencyTrack/dependency-track#2041
DependencyTrack/dependency-track#657
DependencyTrack/dependency-track#2410
#641 (routing Bug)
Fixes #1025
Additional Details
Hint: Screenshots show outdated "HighSemver" functionality, which was exchanged.
Checklist