Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty value in Link directive #5

Open
wants to merge 68 commits into
base: dev
Choose a base branch
from
Open

Fix empty value in Link directive #5

wants to merge 68 commits into from

Conversation

markvl91
Copy link
Collaborator

Add optional chaining to avoid erroring out when Link.field.text is falsy and Link.field.value is undefined.

Corne Elshof and others added 30 commits July 17, 2019 12:37
Added generic text component
2416bef
Merge branch 'dev' of https://github.com/jlast/jss into chore/add-gen…
2b814d8 
…eric-rich-text
Merge branch 'chore/add-generic-rich-text' into dev
37f3b72
Add unit test for rich text link
dbac512
Implemted guard and resolve
7648842
Added ComponentNameAndModule to exports
97b0b88
Added loaded back to placeholder
a6b1c19
Merge classnames on sitecore linkfields
74bec58
Merge classnames
ffd8359
Can register constructor types
726de38
Merge branch 'dev' of https://github.com/Sitecore/jss into guard-concept
13acb3e
Merge branch 'dev' of https://github.com/Idicious/jss into guard-concept
2aa4cc8
Updated lerna
8b50bed
Merge branch 'dev' of https://github.com/jlast/jss into guard-concept
82a5b37
Merge classnames
8ba67d8
Merge classnames on sitecore linkfields
f20c5cd
Add unit test for rich text link
1ae8dcd
Added generic text component
16769de
Merge branch 'guard-concept' of https://github.com/jlast/jss into merged
3bbd293
Merge branch 'lazy-loading' into merged
18b254b
Merge branch 'lazy-loading' into merged
86062be
Merge branch 'lazy-loading' into merged
6466720
Fix typo
c59a1e3
Merge branch 'dev' of https://github.com/Sitecore/jss into merged
da9408d
Allow for observable guards
9d19969
Merge merge
66b0bde
Used correct operators
413b690
Removed unused method
b175360
isloading false after load
f0ec882
Merge branch 'dev' of https://github.com/sitecore/jss into dev
5691177
Jeroen van der Last and others added 29 commits August 14, 2019 15:19
Change type
b41dc47
Merge branch 'loadchildren-import' into dev
b4e2732
Merge branch 'dev' of https://github.com/sitecore/jss into dev
e71fb5c
Added capability for multiple guards per component
e1fc7fd
Added data resolver back
8d0db31
Fixed typings for workspace typescript version
7054f1f
Fixed unit tests
66ea032
Added unit tests for data resolvers and guards
9ad50d0
Added clientOnly input to placeholder
7033db4
Undo package-locks
e43cee1
Merge branch 'dev' of https://github.com/Essent/jss into feature/mult…
d428198 
…iple-guards
Updated package locks
3182540
@jlast
Merge pull request Essent#1 from Essent/feature/multiple-guards
5a67734 
Feature/multiple guards
Updated guards
43ac59c
Merge branch 'master' of https://github.com/Essent/jss into feature/i…
c7d94fb 
…nject-rendering-in-guard
Merge branch 'dev' of https://github.com/Essent/jss into feature/inje…
0cbce92 
…ct-rendering-in-guard
Merge branch 'master' of https://github.com/Essent/jss into dev
888705b
Merge branch 'dev' of https://github.com/Essent/jss into feature/inje…
f24010f 
…ct-rendering-in-guard
@jlast
Merge pull request Essent#2 from Essent/feature/inject-rendering-in-g…
935893b 
…uard

Feature- Inject rendering in guard
Fix queryselectorall
5f0602b
Fix formatting
385c769
@jlast
Merge pull request Essent#3 from Essent/fix-query-selector-all
06b696f 
Fix queryselectorall
@spike1292
Merge branch 'dev' of https://github.com/Sitecore/jss into dev
b743ce7
@spike1292
update locks
8d3da08
@spike1292
upgrade to angular 9
75db02a
Fix link target
a60f76d
@jlast
Merge pull request Essent#4 from Essent/fix-link-target
f2af1fc 
Fix link target
Update local package number
6d99a27
@markvl91
Add optional chaining to avoid erroring out when Link.field.text is f…
b5beffe 
…alsy and Link.field.value is undefined.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markvl91 @jlast @spike1292