-
Notifications
You must be signed in to change notification settings - Fork 72
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Joe Alves
committed
May 31, 2016
1 parent
bc6ec23
commit 594104b
Showing
1 changed file
with
10 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
594104b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also have it where if there is no argument, the new project dir is a new
fsg
folder withinprocess.cwd
? That would avoid my (or someone else's) accidentally creating fsg files in their current directory unexpectedly. The ideal would also be to check if an fsg folder already exists and confirm the user wants to populate it if so — the ultimate in preventing accidents. I would do it myself but I'm in an interview right now (heh).594104b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I would use
path.resolve
in case someone puts in an absolute path as an argument594104b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implemented in #53.