Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Community] [Navigation mesh pathfinding] Fixed problem with Rotation speed not being applied correctly. #1421

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PANDAKO-GitHub
Copy link
Contributor

This PR includes fixes and suggestions.

  • Fixed an issue where rotation speed was not being applied correctly.
  • Added units to properties.
  • Set actions to private that change parameters that cannot be changed later, such as "Change the Cell size."
  • Added a note to the description of the "Draw navigation mesh" action.

@D8H , What do you think about these changes?

~~
This extension is great in that it works when added to a new tile map object.
It would be better if the navigation mesh could be updated when tiles are changed.

This current solution is not very smart.
image

@PANDAKO-GitHub PANDAKO-GitHub requested a review from a team as a code owner October 31, 2024 06:56
@PANDAKO-GitHub PANDAKO-GitHub changed the title Fixed problem with Rotation speed not being applied correctly. [Community] [Navigation mesh pathfinding] Fixed problem with Rotation speed not being applied correctly. Oct 31, 2024
@D8H
Copy link
Contributor

D8H commented Oct 31, 2024

Set actions to private that change parameters that cannot be changed later, such as "Change the Cell size."

What make you think that it can't be changed?
The navmesh should update as soon as a new path is asked.

It would be better if the navigation mesh could be updated when tiles are changed.

It watches the position and size. It would need a change in GDveleop to be able to subscribe to tiles changes.

@PANDAKO-GitHub
Copy link
Contributor Author

What make you think that it can't be changed?

Because I tried it and it didn't work.
Is this usage incorrect?
image

It would need a change in GDveleop to be able to subscribe to tiles changes.

I think this problem can be solved just by adding an action to update the navigation mesh.

@D8H
Copy link
Contributor

D8H commented Oct 31, 2024

Because I tried it and it didn't work. Is this usage incorrect?

It should work, but there will be only 4 rastering cells. It won't be usable.

@PANDAKO-GitHub
Copy link
Contributor Author

PANDAKO-GitHub commented Nov 1, 2024

It should work, but there will be only 4 rastering cells. It won't be usable.

Does that mean the action has no effect?

@D8H
Copy link
Contributor

D8H commented Nov 1, 2024

It should work, but there will be only 4 rastering cells. It won't be usable.

Does that mean the action has no effect?

I meant that it's the right actions, but the parameter values are off.
Did you choose random values just to take a screenshot?
What are the real values you used for your game?

@PANDAKO-GitHub
Copy link
Contributor Author

What are the real values you used for your game?

I set the cell size to 10 in the scene properties and tried changing it to 16 in the actions, but the mesh didn't change.

@D8H
Copy link
Contributor

D8H commented Nov 1, 2024

I set the cell size to 10 in the scene properties and tried changing it to 16 in the actions, but the mesh didn't change.

It won't change unless you ask a new path and the changes will be very small.

@PANDAKO-GitHub
Copy link
Contributor Author

Even if the cell size is the same, the result will vary depending on the process of setting.

2024-11-02 113955

2024-11-02 114445

Events:
2024-11-02 114900

And just to be sure, I will tell you that the action to change the Area bound has no effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants