fix contributions extraction endpoints for non-final deletions #324
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the case when a deletion happens which was reverted later on. These "deletion" contributions are currently missing in the output of
/contributions
extraction endpoints.For example
curl -X GET "https://api.ohsome.org/v1/contributions/geometry?bboxes=-180%2C-90%2C180%2C90&clipGeometry=true&filter=type%3Anode%20and%20id%3A1&properties=tags%2CcontributionTypes&time=2009-01-01%2C2012-01-01" -H "accept: application/json"
, fornode/1
one gets:Note that there is no contribution on
2009-07-07T22:44:41Z
, corresponding to version 4 of the node. This would be the expected result:Checklist
I have commented my codeI have written javadoc (required for public methods)I have made corresponding changes to the documentationI have adjusted the examples in the check-ohsome-api script or created an issue in the corresponding repository. More Information here.