Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash caused by overly complex filters #331

Merged
merged 1 commit into from
Aug 9, 2024
Merged

fix crash caused by overly complex filters #331

merged 1 commit into from
Aug 9, 2024

Conversation

tyrasd
Copy link
Member

@tyrasd tyrasd commented Aug 9, 2024

instead of iterating through the normalized filter, this checks for the presence of non-snapshot compatible filters by recursively searching through the filter tree.

Fixes #330

Checklist

  • My code follows the code-style rules, and I have checked on the static analyses
  • I have commented my code
  • [ ] I have written javadoc (required for public methods)
  • [ ] I have added sufficient unit and API tests
  • [ ] I have made corresponding changes to the documentation
  • I have updated the CHANGELOG.md
  • [ ] I have adjusted the examples in the check-ohsome-api script or created an issue in the corresponding repository. More Information here.

@tyrasd tyrasd requested a review from rtroilo August 9, 2024 13:45
instead of iterating through the normalized filter, this checks for the presence of non-snapshot compatible filters by recursively searching through the filter tree.
Copy link
Member

@rtroilo rtroilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪🏽

@tyrasd tyrasd merged commit 176743f into main Aug 9, 2024
2 checks passed
@tyrasd tyrasd deleted the issue-330 branch August 9, 2024 15:41
@tyrasd tyrasd changed the title fix crash caused by overly complex filters, fixes #330 fix crash caused by overly complex filters Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swagger returns status code 500, but the cURL command returns status code 400
2 participants