-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set CMAKE_BUILD_PARALLEL_LEVEL environment variable. #18558
base: master
Are you sure you want to change the base?
Conversation
…ariable. `cmake` builds previously did not respect `HOMEBREW_MAKE_JOBS`. This change fixes that.
3f7da97
to
d6fd0f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks OK.
Though not entirely sure what scenario this would have applied given cmake
already respects MAKEFLAGS
which we set? Do you have a reproducer?
Need to update As far as I can tell:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update ENV.deparallelize
too (as mentioned by @cho-m).
Marking as request changes just to ensure it's not merged by mistake before that.
Yes. I have a old Mac running MacOS Big Sur 11.7.10 (the latest version of the OS supported on this Mac) so homebrew needs to compile packages when I install them. My Mac has 8 cores and 16 GB RAM and some of the builds occasionally fails because they run out of memory, with 8 cmake jobs running. I tried setting |
Kinda weird that it doesn't, since |
CMake uses brew/Library/Homebrew/extend/ENV/super.rb Lines 257 to 260 in 215064e
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
cmake
builds previously did not respectHOMEBREW_MAKE_JOBS
. This change fixes that.brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?