-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tableau-public 2024.3.0 #191077
base: master
Are you sure you want to change the base?
tableau-public 2024.3.0 #191077
Conversation
f71c8df
to
b8294c3
Compare
I've verified that this version of the app is still using the same source when checking for updates, but it hasn't been updated yet. @samford Any concerns with merging this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've verified that this version of the app is still using the same source when checking for updates, but it hasn't been updated yet. Any concerns with merging this?
If the Public app checks the same XML file, then I suppose we can assume that Desktop and Public versions are strictly aligned. TableauAutoUpdate.xml
references TableauDesktop
files (not TableauPublic
) and both tableau
/tableau-public
use the same check. [I'll create a separate PR to update the -prep
/-public
/-reader
livecheck
blocks to use cask references instead of duplicating the livecheck
block (#192118), as tableau
can potentially be seen as the parent cask.]
The highest version on the Desktop releases page is 2024.3 ("Released Oct 15, 2024") but 2024.2.4 was released later on Oct 24, 2024. The highest version in the XML file is 2024.2.4, so the file has been updated after the 2024.3 release but it doesn't include it. There's no way to tell if upstream has intentionally omitted 2024.3 (to prevent users from upgrading to it until sometime in the future) or if they just haven't made some technical change to include it in the XML file.
How we handle this mismatch depends on if our aim is to replicate the same behavior as the auto-update logic in the application or if we just want to use the highest released version. If it's the former then we can mark this as a draft and wait for the XML file to include 2024.3.0. If it's the latter, then we would need to update the livecheck
block to check the releases page instead.
I put together a livecheck
block that checks the releases page (it also requires a strategy
block to add .0
to two-part versions), so I can push that here if we go that route.
tableau-public: update sha256 and curl user_agent version Signed-off-by: Patrick Linnane <[email protected]>
fe0b984
to
277f4a8
Compare
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>
is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>
is error-free.brew style --fix <cask>
reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>
worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>
worked successfully.brew uninstall --cask <cask>
worked successfully.