Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shaka-packager 3.4.0 (new cask) #192144

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

garnajee
Copy link

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@BrewTestBot BrewTestBot added new cask missing zap Cask is missing a zap stanza, please add one. labels Nov 15, 2024
Copy link
Member

@daeho-ro daeho-ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comment.
I saw that there are intel version too, so you may add it with arch stanza.

Casks/s/shaka-packager.rb Outdated Show resolved Hide resolved
Casks/s/shaka-packager.rb Outdated Show resolved Hide resolved
@daeho-ro daeho-ro changed the title Add shaka-packager Cask shaka-packager 3.4.0 (new cask) Nov 15, 2024
@BrewTestBot BrewTestBot removed the missing zap Cask is missing a zap stanza, please add one. label Nov 15, 2024
@garnajee
Copy link
Author

garnajee commented Nov 15, 2024

Thanks for your feedback! Regarding the sha256 line, since we now have both Intel and ARM support for the shaka-packager binary, I'm not entirely sure how to handle this part. Do we need to include two separate sha256 checksums? If so, how?
edit: i found how to do it.

I hope this modification works for you, but feel free to let me know if you have any suggestions on how to handle this.

@daeho-ro daeho-ro force-pushed the add-shaka-packager-cask branch 2 times, most recently from ad236ce to 39213c0 Compare November 15, 2024 15:06
@daeho-ro
Copy link
Member

caveats is allowed only for the Homebrew specfic one, and yours are quite general so I deleted and squash your commits.

@daeho-ro
Copy link
Member

daeho-ro commented Nov 15, 2024

Hm... signing problem only for intel. Is this can be fixed? Or should we go only with arm?

@garnajee
Copy link
Author

Hm... signing problem only for intel. Is this can be fixed? Or should we go only with arm?

Well i don't know...
I just sha256sum packager-osx-x64.

I only did arm64 at first, because all the new Macs (since M1 2020) are equipped with arm chips. that was why I chose it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants