-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shaka-packager 3.4.0 (new cask) #192144
base: master
Are you sure you want to change the base?
shaka-packager 3.4.0 (new cask) #192144
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comment.
I saw that there are intel version too, so you may add it with arch stanza.
Thanks for your feedback! I hope this modification works for you, but feel free to let me know if you have any suggestions on how to handle this. |
ad236ce
to
39213c0
Compare
|
39213c0
to
2a52eb0
Compare
Hm... signing problem only for intel. Is this can be fixed? Or should we go only with arm? |
Well i don't know... I only did arm64 at first, because all the new Macs (since M1 2020) are equipped with arm chips. that was why I chose it. |
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>
is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>
is error-free.brew style --fix <cask>
reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>
worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>
worked successfully.brew uninstall --cask <cask>
worked successfully.