Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drm: Document supported environment variables #530

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

aperezdc
Copy link
Member

Add the missing documentation for the environment variables honored by the DRM/KMS platform plug-in.

Add the missing documentation for the environment variables honored by
the DRM/KMS platform plug-in.
@aperezdc aperezdc added the enhancement New feature or request label Jan 16, 2023
@aperezdc aperezdc self-assigned this Jan 16, 2023
Copy link
Member

@ceyusa ceyusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ceyusa
Copy link
Member

ceyusa commented Jan 17, 2023

As a non-actionable comment, I'm a bit wary about environment variables and it potential abuse (such as changing values in run time). All the configuration envvars are also parsed in the configuration file? IMO these documented envvars make more sense in a configuration file rather than envvars.

@aperezdc
Copy link
Member Author

As a non-actionable comment, I'm a bit wary about environment variables and it potential abuse (such as changing values in run time). All the configuration envvars are also parsed in the configuration file? IMO these documented envvars make more sense in a configuration file rather than envvars. I have filed #531 to try and reduce their usage.

While in most (even all?) cases in Cog we only read environment variables once at initialization (which is okay), I do agree that changing them to be parameters and/or config file entries is desirable in most cases. That's why platform plug-in parameters were added, and then the config file... Also I made #363 to explore how to unify configuration parameters as object properties as a first step towards abandoning most environment variables, but there has been no comments there whatsoever 🤷🏼

@aperezdc aperezdc merged commit 38c7d53 into master Jan 17, 2023
@aperezdc aperezdc deleted the aperezdc/drm-env-vars branch January 17, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants