Improve the propagation of explanations when a Spec fails. #4739
+430
−193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Conway/WitnessUniverse.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Conway/ParametricSpec.hs
Outdated
Show resolved
Hide resolved
MaximilianAlgehed
requested changes
Nov 6, 2024
Soupstraw
reviewed
Nov 6, 2024
TimSheard
force-pushed
the
ts-better-explanations
branch
from
f4a840b
to
aa9bbf2
Compare
TimSheard
force-pushed
the
ts-better-explanations
branch
5 times, most recently
from
19c01e0
to
9074791
Compare
MaximilianAlgehed
requested changes
Nov 13, 2024
Soupstraw
reviewed
Nov 13, 2024
TimSheard
force-pushed
the
ts-better-explanations
branch
from
9074791
to
ed0edbc
Compare
TimSheard
force-pushed
the
ts-better-explanations
branch
2 times, most recently
from
6c4f245
to
259577d
Compare
The function explainSpec no longer drops explanations on TypeSpec Added guardTypeSpec, which catches errors earlier, so there is less noise. function symbols like subset_ and member_ print a elided version of their set arguments when they are large literals. Improves readabilty as irrelevant information no longer overwhelms the user. Add the constructor ExplainSpec to Specification Assert now has type Assert :: Term fn Bool -> Pred fn
TimSheard
force-pushed
the
ts-better-explanations
branch
from
259577d
to
16f5cf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the error messages when a Spec fails.
The function explainSpec no longer drops explanations.
Added guardTypeSpec, which catches errors earlier, so there is less noise.
Function symbols like subset_ and member_ print more compactly.
Description
Checklist
CHANGELOG.mdfor the affected packages.New section is never added with the code changes. (See RELEASING.md)
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated.If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)