Manage Kotlin native cache kind automatically based on Kotlin version #3477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexeyTsvetkov
force-pushed
the
kotlin-native-caching-settings
branch
from
9a466a7
to
1939de0
Compare
AlexeyTsvetkov
force-pushed
the
kotlin-native-caching-settings
branch
from
1939de0
to
b85c275
Compare
dima-avdeev-jb
approved these changes
Aug 11, 2023
...rc/main/kotlin/org/jetbrains/compose/experimental/internal/configureNativeCompilerCaching.kt
Show resolved
Hide resolved
MatkovIvan
reviewed
Aug 11, 2023
...rc/main/kotlin/org/jetbrains/compose/experimental/internal/configureNativeCompilerCaching.kt
Show resolved
Hide resolved
...rc/main/kotlin/org/jetbrains/compose/experimental/internal/configureNativeCompilerCaching.kt
Outdated
Show resolved
Hide resolved
pjBooms
requested changes
Aug 11, 2023
...rc/main/kotlin/org/jetbrains/compose/experimental/internal/configureNativeCompilerCaching.kt
Outdated
Show resolved
Hide resolved
...rc/main/kotlin/org/jetbrains/compose/experimental/internal/configureNativeCompilerCaching.kt
Show resolved
Hide resolved
...rc/main/kotlin/org/jetbrains/compose/experimental/internal/configureNativeCompilerCaching.kt
Show resolved
Hide resolved
pjBooms
approved these changes
Aug 11, 2023
|
Checked removing |
AlexeyTsvetkov
added a commit
to AlexeyTsvetkov/compose-jb
that referenced
this pull request
Aug 16, 2023
We tried to enable the compiler cache, when Kotlin/Native 1.9.0 is used. Prior to Kotlin 1.9.0, the caching could not be used with Compose, because code generation would fail. With Kotlin 1.9.0, code generation succeeds, but generated debug symbols cause issues with dsymutil during xcode build. For more details, see https://youtrack.jetbrains.com/issue/KT-61270 This change partially reverts JetBrains#3477 and JetBrains#3496 Now, we always set `kotlin.native.cacheKind=none` in Compose Multiplatform Gradle plugin for all versions of Kotlin until KT-61270 is fixed. Also, explicit cache kind error becomes a warning again.
AlexeyTsvetkov
added a commit
that referenced
this pull request
Aug 16, 2023
We tried to enable the compiler cache, when Kotlin/Native 1.9.0 is used. Prior to Kotlin 1.9.0, the caching could not be used with Compose, because code generation would fail. With Kotlin 1.9.0, code generation succeeds, but generated debug symbols cause issues with dsymutil during xcode build. For more details, see https://youtrack.jetbrains.com/issue/KT-61270 This change partially reverts #3477 and #3496 Now, we always set `kotlin.native.cacheKind=none` in Compose Multiplatform Gradle plugin for all versions of Kotlin until KT-61270 is fixed. Also, explicit cache kind error becomes a warning again.
igordmn
pushed a commit
that referenced
this pull request
Aug 16, 2023
We tried to enable the compiler cache, when Kotlin/Native 1.9.0 is used. Prior to Kotlin 1.9.0, the caching could not be used with Compose, because code generation would fail. With Kotlin 1.9.0, code generation succeeds, but generated debug symbols cause issues with dsymutil during xcode build. For more details, see https://youtrack.jetbrains.com/issue/KT-61270 This change partially reverts #3477 and #3496 Now, we always set `kotlin.native.cacheKind=none` in Compose Multiplatform Gradle plugin for all versions of Kotlin until KT-61270 is fixed. Also, explicit cache kind error becomes a warning again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.