Added Ubuntu Perforce package #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also resolves #24 |
Merge upstream changes
# Conflicts: # ubuntu/Dockerfile
Updated fork with latest from base
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Perforce binary to Ubuntu Dockerfile. Its installed using the instructions supplied by Perforce, and done using os-release so that it will install the correct package regardless of any base image changes.
Doing so required an intermediary gnupg package that is only installed during the build and then removed immediately. I also took the liberty of cleaning the downloaded apt lists which reduces the overall image size, and is recommended in the Docker Best Practices. I also modified the existing RUN command to follow these practices as well, such as moving the install packages to new lines for better diffs and ordering them alphabetically. I also moved the AND operators to the front as its easier to see which lines are a new command versus an argument.