Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give Diffractor an AbstractDifferentiation interface #187

Merged
merged 4 commits into from
Jul 26, 2023

Conversation

oscardssmith
Copy link
Member

This actually passes tests.

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch coverage: 83.33% and project coverage change: +1.73% 🎉

Comparison is base (8af6de2) 53.25% compared to head (a1e8810) 54.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
+ Coverage   53.25%   54.98%   +1.73%     
==========================================
  Files          27       28       +1     
  Lines        2783     2790       +7     
==========================================
+ Hits         1482     1534      +52     
+ Misses       1301     1256      -45     
Files Changed Coverage Δ
src/interface.jl 67.39% <66.66%> (-1.36%) ⬇️
src/AbstractDifferentiation.jl 87.50% <87.50%> (ø)
src/Diffractor.jl 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oxinabox
Copy link
Member

Do we have tests of these?

@staticfloat
Copy link
Collaborator

Yes, tests please.

@oxinabox oxinabox changed the title Give Diffractor a ForwardDiff inspired interface v2 Give Diffractor an AbstractDifferentiation interface Jul 25, 2023
@oxinabox
Copy link
Member

Oops we forgot to merge this 😂
time for 0.2.1

@oxinabox oxinabox mentioned this pull request Jul 26, 2023
Copy link
Member

@oxinabox oxinabox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please merge and tag as soon as CI passes

@oxinabox oxinabox merged commit 0318546 into JuliaDiff:main Jul 26, 2023
6 of 8 checks passed
@oxinabox
Copy link
Member

CI break on nightly is unrelated

@oscardssmith oscardssmith deleted the add-interface-v2 branch July 26, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants