-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give Diffractor an AbstractDifferentiation interface #187
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #187 +/- ##
==========================================
+ Coverage 53.25% 54.98% +1.73%
==========================================
Files 27 28 +1
Lines 2783 2790 +7
==========================================
+ Hits 1482 1534 +52
+ Misses 1301 1256 -45
☔ View full report in Codecov by Sentry. |
Do we have tests of these? |
Yes, tests please. |
de65c8e
to
775f3ac
Compare
Oops we forgot to merge this 😂 |
775f3ac
to
a1e8810
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please merge and tag as soon as CI passes
CI break on nightly is unrelated |
This actually passes tests.