Adjust to upstream edges change #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @vtjnash |
vtjnash
approved these changes
Nov 5, 2024
aviatesk
approved these changes
Nov 5, 2024
Comment on lines
+80
to
+83
| function CC.add_edges_impl(edges::Vector{Any}, info::FRuleCallInfo) | ||
| CC.add_edges!(edges, info.info) | ||
| CC.add_edges!(edges, info.frule_call.info) | ||
| end |
There was a problem hiding this comment.
I don’t think this implementation allows the method table backedge equivalent to CC.add_mt_backedge!(sv, frule_mt, frule_atype) to be created, but I also think this should be sufficient for the purpose of invalidating when a new frule is added—which was the reason for adding add_mt_backedge!. In the current implementation, a backedge is added to the fallback frule(...), which I think should trigger equivalent invalidation.
There was a problem hiding this comment.
Right, the point was to trigger on additions of new signatures that would change the lookup result. My understanding is that the callinfo encodes exactly the lookup we want, so this should do what we need.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.