Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiset_permutations method that doesn't require length #164

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

oscardssmith
Copy link
Member

in analogy to the same case for regular permuations

in analogy to the same case for regular `permuations`
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 96.41%. Comparing base (a303e88) to head (6afa6f0).

❗ Current head 6afa6f0 differs from pull request most recent head 2813a19. Consider uploading reports for the commit 2813a19 to get more accurate results

Files Patch % Lines
src/permutations.jl 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
- Coverage   96.89%   96.41%   -0.48%     
==========================================
  Files           8        8              
  Lines         804      808       +4     
==========================================
  Hits          779      779              
- Misses         25       29       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@inkydragon
Copy link
Member

Maybe add some tests or doctests

@oscardssmith
Copy link
Member Author

test added.

@oscardssmith
Copy link
Member Author

should this be merged?

src/permutations.jl Outdated Show resolved Hide resolved
Co-authored-by: Thomas Christensen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants