translate most functions in erf.jl in Julia's form #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you make a plot of the ratios new/old of the minimum (not median) times? |
|
@ziyixi Could you update the link to the notebook, it seems dead. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translate most functions in erf.jl except for functions with the BigFloat input. The code is directly translated from apple's libm for erf(x::Float64), erfc(x::Float64) and libopenspecfun for the other functions. The licenses of both the libs are MIT so I could directly translate them .
All the functions have passed the tests. And you could see the benchmark in https://github.com/ziyixi/gsoc-work/blob/master/benchmark.ipynb .