Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix method 2 and 3 responsibilities #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stefanches7
Copy link

should do the trick for #26

@Tokazama
Copy link
Member

Tokazama commented Jan 9, 2020

Thanks for the PR! , but we'll need something more involved in the future to fix the entire sform/qform situation here. The short explanation is that eventually we want to have both qform and sform, atleast when writing to a file. However, the NIfTI standard makes this a bit more complicated than moving between an affine mapping and quaternion.

If this is solves #26 then I think this is a probably a good enough fix for now. @saurvs, does this fix your use case? Could we have some sort of tests to ensure we don't break this in the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants