Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(all and breaking): removed clumbersome namespace setup in favor of simply getResource(); #12

Merged
merged 4 commits into from
Aug 29, 2024

Conversation

KemingHe
Copy link
Owner

No description provided.

…ruce functions

* removed osu namespace exports * using zod schema and inferred types instead of native typescirpt
interface for added validation security * added dups remover to generator scripts * planned support
for future real-time data-fetching via jsdom experiments (not included yet) * revised readme to
reflect and warn breaking changes

BREAKING CHANGE: * renamed isOSUEmail to isOSUDotEduEmail for clarity * renamed isNameDotNumber to
isNameDotNum for brivety * completely removed the osu namespace and sub-spaces in favor of importing
getResource functions to simplify usage
@KemingHe KemingHe added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 29, 2024
@KemingHe KemingHe self-assigned this Aug 29, 2024
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (573ab84) to head (728ce6b).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main       #12     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files            5        12      +7     
  Lines        18788     22447   +3659     
  Branches         7         7             
===========================================
+ Hits         18788     22447   +3659     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

… pnpm custom version

GitHub Actions workflow pnpm version will be automatically determined by packageManager field in
package.json
@KemingHe KemingHe merged commit 4e94b64 into main Aug 29, 2024
12 of 23 checks passed
@KemingHe KemingHe deleted the feature-removednamespace-keminghe branch August 29, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant