Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noticed a regression for Input Number while testing on webapp. Testing this logic fix #1866

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

SonicScrewdriver
Copy link
Contributor

@SonicScrewdriver SonicScrewdriver commented Nov 15, 2024

Summary:

Discovered a regression after addressing some PR feedback for the InputNumber Conversion project. This small change ensures that we're getting the proper result for conversionWarningRequired in the Article Renderer.

Screenshot:

Screenshot 2024-11-14 at 5 26 03 PM

Issue: None

Test plan:

  • Manual Testing
  • Snapshot testing in Webapp

@SonicScrewdriver SonicScrewdriver self-assigned this Nov 15, 2024
Copy link
Contributor

github-actions bot commented Nov 15, 2024

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (3afd4f5) and published it to npm. You
can install it using the tag PR1866.

Example:

yarn add @khanacademy/perseus@PR1866

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1866

Copy link
Contributor

github-actions bot commented Nov 15, 2024

Size Change: +72 B (+0.01%)

Total Size: 1.29 MB

Filename Size Change
packages/perseus-editor/dist/es/index.js 699 kB +19 B (0%)
packages/perseus/dist/es/index.js 420 kB +53 B (+0.01%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.9 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 77.8 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/perseus/dist/es/strings.js 3.54 kB
packages/pure-markdown/dist/es/index.js 3.66 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

@SonicScrewdriver SonicScrewdriver marked this pull request as ready for review November 15, 2024 01:21
@khan-actions-bot khan-actions-bot requested a review from a team November 15, 2024 01:21
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Nov 15, 2024

Gerald

Required Reviewers
  • @Khan/perseus for changes to .changeset/moody-dingos-relate.md, .changeset/quick-mangos-end.md, packages/perseus-editor/src/article-editor.tsx, packages/perseus/src/widgets/numeric-input/numeric-input.tsx, packages/perseus-editor/src/util/deprecated-widgets/input-number.ts

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants