Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): deck integration tests checkout secret #13877

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

samugi
Copy link
Member

@samugi samugi commented Nov 15, 2024

note: do not cherry-pick to EE

Summary

The checkout step of these tests was using a secret that is not available to PRs opened from forks, which made it fail. This commit removes the token (not needed in CE), which makes the action fall back to the default github token.

Checklist

  • (no) The Pull Request has tests
  • (no) A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • (no) There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

@samugi samugi changed the title fix(ci): deck integration tests checkout secret chore(ci): deck integration tests checkout secret Nov 15, 2024
@github-actions github-actions bot added the chore Not part of the core functionality of kong, but still needed label Nov 15, 2024
The checkout step of these tests was using a secret that is not
available to PRs opened from forks, which made it fail.
This commit removes the token (not needed in CE), which makes the action
fall back to the default github token.

It also adds the workflow to the `paths`, just to make sure it runs when
modified.
@samugi samugi merged commit 8a295b8 into master Nov 15, 2024
29 checks passed
@samugi samugi deleted the chore/deck-integration-fork branch November 15, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Not part of the core functionality of kong, but still needed size/XS skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants