-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix outdated reg names in deployment samples #189
base: main
Are you sure you want to change the base?
Conversation
Currently deployment samples `WV2DeploymentWiXCustomActionSample` and `WV2DeploymentWiXBurnBundleSample` use the reg name `EBWebView` for registry searching, but this entry has already disappeared in recent versions of WVRT (also disappeared in Edge Stable). ![](https://github.com/MicrosoftEdge/WebView2Samples/assets/20179549/54090887-3b70-4e90-90fb-1f061e26963e) ![](https://github.com/MicrosoftEdge/WebView2Samples/assets/20179549/d3937bb9-b278-4db0-8c11-3dee80feae97) Changed them to `pv`, consistent with `WV2DeploymentVSInstallerSample`. Also I noticed that these three registry searches were introduced in the same PR (MicrosoftEdge#56). Are there any special considerations for the inconsistency here? Related commit: MicrosoftEdge@8402697
@ilharp please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
@microsoft-github-policy-service agree |
Currently deployment samples
WV2DeploymentWiXCustomActionSample
andWV2DeploymentWiXBurnBundleSample
use the reg nameEBWebView
for registry searching, but this entry has already disappeared in recent versions of WVRT (also disappeared in Edge Stable).Changed them to
pv
, consistent withWV2DeploymentVSInstallerSample
.Also I noticed that these three registry searches were introduced in the same PR (#56). Are there any special considerations for the inconsistency here?
Related commit:
8402697