Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Cleanup #20

Open
CMahaff opened this issue Sep 4, 2013 · 2 comments
Open

Code Cleanup #20

CMahaff opened this issue Sep 4, 2013 · 2 comments
Labels
enhancement high priority

Comments

@CMahaff
Copy link
Contributor

CMahaff commented Sep 4, 2013

Formatting, possibly get rid of extraneous spaces?

ex. $ ( '#something' ) is kind of crazy
CMahaff added a commit that referenced this issue Sep 4, 2013
@CMahaff
Fixed a few small outstanding bugs, including errors if time expires …
bb5617a 
…- Issue #20
@CMahaff
Copy link
Contributor Author

CMahaff commented Sep 6, 2013

Just sitting a note here. Currently the logout button and error message button are created in LoginScreen and never "destroyed". This is appropriate because both should be on for the entire game (well, at the very least the logout button).

I think it's fine, but if there is a "better place" to put them, feel free.

CMahaff referenced this issue Sep 10, 2013
@CMahaff
Moved mouse events to JavaScript instead of html onmouse___ = calls
be2c436
CMahaff referenced this issue Sep 10, 2013
@CMahaff
Pressing enter in the password box or password repeat box now perform…
057402d 
…s the button press
CMahaff added a commit that referenced this issue Sep 11, 2013
@CMahaff
Removed some unnecessary comments, added a few, reorganized methods t…
92bf457 
…o a more logical order, and other small things - Issue #20
@CMahaff
Copy link
Contributor Author

CMahaff commented Sep 11, 2013

Change all <br /> to just <br> ?

mfansler added a commit that referenced this issue Sep 17, 2013
@mfansler
jquery improvements; issue #20
de40f84
mfansler added a commit that referenced this issue Sep 17, 2013
@mfansler
switched to forEach iteration; issue #20
e9e62e3
CMahaff added a commit that referenced this issue Oct 21, 2013
@CMahaff
Fixed some graphical bugs that got introduced during the CSS cleanup …
b362aa8 
…- Issue #20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement high priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CMahaff