Fixed double hyphen on docker set up script #9316
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the convenience script for mac is failing because in the docs it says to use a double hyphen before email and password but it was expecting a single hyphen in the file. I've updated the script so that both precedents work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the docker convenience script for mac is failing because in the docs it says to use a double hyphen before email and password but it was expecting a single hyphen in the file. I've updated the script so that both precedents work.
Description
I was running through the demo and the convenience script was failing. After a very quick debug I found an inconsistency between the command instruction in the documentation and the script flags. I added an option for each for the command as it is given in the documentaion.
Affected Dependencies
None
How has this been tested?
I have run it in my terminal (OSX):
Before (the issue):
`(base) adamhall@Adams-MacBook-Pro scripts % bash docker-setup.sh -v 0.8.2-beta.6 -n my_server_1 -s high -t datasite -p 8081 --password mypassword --email myemail'
Usage: docker-setup.sh -v|--version -n|--name <server_name> -t|--type <server_type> -p|--port [-s|--side <server_side_type>] [-email|--root-email <default_root_email>] [--password|--root-password <default_root_password>]
(base) adamhall@Adams-MacBook-Pro scripts % `
After the edits (and I updated the server version as the one in the docs is no longer available):
(base) Adams-MacBook-Pro:scripts adamhall$ bash docker-setup.sh -v 0.9.1-beta.11 -n my_server_1 -s high -t datasite -p 8081 --password mypassword --email myemail VERSION: 0.9.1-beta.11 SERVER_NAME: my_server_1 SERVER_SIDE_TYPE: high SERVER_TYPE: datasite PORT: 8081 DEFAULT_ROOT_EMAIL: myemail DEFAULT_ROOT_PASSWORD: mypassword Unable to find image 'openmined/syft-backend:0.9.1-beta.11' locally 0.9.1-beta.11: Pulling from openmined/syft-backend fc94bb2b60b6: Pull complete 17f8ee582a51: Pull complete 1483371d4790: Pull complete 68a809891839: Downloading 13.4MB/315.3MB fa13eea5e371: Waiting 6f448285cc53: Waiting ^C got 3 SIGTERM/SIGINTs, forcefully exitingChecklist