Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer): form warnings always show in form #16846

Open
wants to merge 1 commit into
base: edge
Choose a base branch
from

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Nov 15, 2024

clsoes RQA-3598

Overview

Fixes when form warnings and timeline warnings render when editing a form

Test Plan and Hands on Testing

Upload the attached protocol and edit the transfer step. the tube warning should be visible

Then, make a new protocol with no liquids and a tuberack and single channel pipette. Make a transfer step and transfer in and out of the tube. Create the step and edit it, you should see both the tube form warning and a "no liquids in well" timeline warning. they should be dismissible.

Changelog

  • refactor formAlert logic to always show form warnings and form errors
  • fix test
  • refactor prop name to only encompass form errors

Risk assessment

low

@jerader jerader requested a review from a team as a code owner November 15, 2024 14:11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants