Add progress percentage to book overview #2424
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a book is in progress the progress percentage is displayed iun both list and grid layouts of the book overview. Previews for list and grid items have also been added.
If the book is not in progress the bottom padding would have been removed inadvertently.
|
And now I look at the open PRs and see #2334 from only a couple of months ago. |
There's probably no need for the progress percentage to be more accurate than a whole number.
…overview' into add-progress-percentage-to-book-overview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a book is in progress the progress percentage is displayed in both list and grid layouts of the book overview.
Previews for list and grid items have also been added.
Note
I'm posting this PR because progress percentage is something I frequently want when I'm listening to an audiobook. I like to update my progress on book tracking websites (e.g. Bookwyrm or Goodreads), and they only accept page numbers or percentage, not remaining time in hours, minutes, and seconds.
I've tried my best to adhere to the formatting of the files I've edited, but I'll happily make changes if something is amiss.