Only fetch unread items on initial list download

https://getpocket.atlassian.net/browse/IN-267
Pocket · Aug 31, 2021 · 0f108d5 · 0f108d5
1 parent a253660
commit 0f108d5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/PocketKit/Sources/Sync/Operations/FetchList.swift b/PocketKit/Sources/Sync/Operations/FetchList.swift
@@ -63,6 +63,8 @@ class FetchList: AsyncOperation {
 
         if let updatedSince = lastRefresh.lastRefresh {
             query.savedItemsFilter = SavedItemsFilter(updatedSince: updatedSince)
+        } else {
+            query.savedItemsFilter = SavedItemsFilter(status: .unread)
         }
 
         return try await apollo.fetch(query: query)

diff --git a/PocketKit/Tests/SyncTests/Operations/FetchListTests.swift b/PocketKit/Tests/SyncTests/Operations/FetchListTests.swift
@@ -209,13 +209,13 @@ class FetchListTests: XCTestCase {
         XCTAssertEqual(call.query.savedItemsFilter?.updatedSince, 123456789)
     }
 
-    func test_refresh_whenUpdatedSinceIsNotPresent_doesNotIncludeUpdatedSinceFilter() {
+    func test_refresh_whenUpdatedSinceIsNotPresent_onlyFetchesUnreadItems() {
         apollo.stubFetch(toReturnFixturedNamed: "list", asResultType: UserByTokenQuery.self)
 
         performOperation()
 
         let call: MockApolloClient.FetchCall<UserByTokenQuery> = apollo.fetchCall(at: 0)
-        XCTAssertNil(call.query.savedItemsFilter)
+        XCTAssertEqual(call.query.savedItemsFilter?.status, .unread)
     }
 
     func test_refresh_whenResultsAreEmpty_finishesOperationSuccessfully() {