Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream: Change Stores to generators for biomass #255

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lindnemi
Copy link
Collaborator

@lindnemi lindnemi commented Oct 22, 2024

Upstream PR: PyPSA/pypsa-eur#1372

  • Adjust the exporter to correctly account biomass trade
  • Double check biomass primary energy

Before asking for a review for this PR make sure to complete the following checklist:

  • Workflow with target rule ariadne_all completes without errors
  • The logic of export_ariadne_variables has been adapted to the changes
  • One or several figures that validate the changes in the PR have been posted as a comment
  • A brief description of the changes has been added to Changelog.md
  • The latest main has been merged into the PR
  • The config has a new prefix of the format YYYYMMDDdescriptive_title

Copy link

github-actions bot commented Oct 22, 2024

Validator Report

I am the Validator. Download all artifacts here.
I'll be back and edit this comment for each new commit.

⚠️ Config changes detected!

Results may differ due to these changes:

diff --git a/config/config.yaml b/config/config.yaml
index 1c8b411..24606b3 100644
--- a/config/config.yaml
+++ b/config/config.yaml
@@ -4,7 +4,7 @@
 
 # docs in https://pypsa-eur.readthedocs.io/en/latest/configuration.html#run
 run:
-  prefix: 20241017_restrict_FT_cap
+  prefix: 20241022_biogenerators
   name:
   # - CurrentPolicies
   - KN2045_Bal_v4

Ariadne Variables

Comparison
NRMSE Pearson
Capacity|Electricity|Storage Converter 0.539 0.034
Secondary Energy|Electricity|Hydro 0.476 -0.469
Price|Secondary Energy|Gases|Hydrogen 0.381 0.000
Capacity|Heat|Non-Renewable Waste 0.209 0.970
Capacity|Electricity|Gas|OC 0.204 0.926
Capacity|Electricity|Non-Renewable Waste 0.203 0.972
Primary Energy|Waste|Heat 0.167 0.964
Investment|Energy Supply|Electricity|Non-Renewable Waste 0.166 0.956
Investment|Energy Supply|Heat|Non-Renewable Waste 0.166 0.956
Secondary Energy|Heat|Waste 0.165 0.964
Final Energy|Waste 0.165 0.964
Primary Energy|Waste 0.165 0.964
Primary Energy|Waste|Electricity 0.161 0.966
Secondary Energy|Electricity|Waste 0.160 0.967
Investment|Energy Supply|Heat|Biomass 0.155 1.000
Investment|Energy Supply|Electricity|Biomass|w/o CCS 0.155 1.000
Investment|Energy Supply|Electricity|Biomass 0.155 1.000
Investment|Energy Supply|Heat|Biomass|w/o CCS 0.155 1.000
Investment|Energy Supply|Electricity|Biomass|Solids 0.155 1.000
Capacity Additions|Heat|Non-Renewable Waste 0.143 0.949
Capacity Additions|Electricity|Non-Renewable Waste 0.137 0.953
Capacity Additions|Heat|Biomass|w/o CCS 0.110 1.000
Capacity Additions|Electricity|Biomass 0.110 1.000
Capacity Additions|Electricity|Biomass|Solids 0.110 1.000
Capacity Additions|Heat|Biomass 0.110 1.000
Capacity Additions|Electricity|Biomass|w/o CCS 0.110 1.000

NRMSE: Normalized (combined-min-max) Root Mean Square Error
Pearson: Pearson correlation coefficient
Threshold: NRMSE > 0.1
Only variables reaching the threshold are shown. Find the equivalent plot for all of them below.

Plots
Main branch Feature branch
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
⚠️ Note: Only the first 20 variables are shown, but more are above the threshold. Find all of them in the artifacts.

General

Plots comparison
Main branch Feature branch
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Image not available Image not available
Files comparison
Status NRMSE MAE (norm)
csvs/metrics.csv ⚠️Changed 0.000 0.08
csvs/curtailment.csv ⚠️Changed 0.000 0.07
csvs/price_statistics.csv ⚠️Changed 0.001 0.19
csvs/cumulative_cost.csv ⚠️Changed 0.000 0.09
csvs/nodal_cfs.csv ⚠️ NaN mismatch
csvs/nodal_supply_energy.csv ⚠️ NaN mismatch
csvs/nodal_costs.csv ⚠️ NaN mismatch
csvs/nodal_capacities.csv ⚠️ NaN mismatch
csvs/capacities.csv ✅ Almost equal 0.000 0.01
csvs/market_values.csv ✅ Almost equal 0.014 0.04
csvs/supply.csv ✅ Almost equal 0.002 0.00
csvs/prices.csv ✅ Almost equal 0.002 0.04
csvs/cfs.csv ✅ Almost equal 0.038 0.00
csvs/costs.csv ✅ Almost equal 0.000 0.01
csvs/supply_energy.csv ✅ Almost equal 0.000 0.01
csvs/energy.csv ✅ Almost equal 0.000 0.01
csvs/weighted_prices.csv ✅ Equal

NRMSE: Normalized (combined-min-max) Root Mean Square Error
MAE (norm): Mean Absolute Error on normalized data (min-max)
Status Threshold: MAE (norm) > 0.05 and NRMSE > 0.3

Model Metrics

Benchmarks Image not available Image not available Image not available

Comparing biogenerators (9156999) with main (d7f78d7).
Branch is 1 commits ahead and 0 commits behind.
Last updated on 2024-10-22 17:10:32 CEST.

@lindnemi lindnemi marked this pull request as ready for review October 28, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant